tests: chore - rename namespace

- namespace should be unique for test-files.
- because of the 1on1: service-path <-> Model relation
- otherwise event-emitters for services call wrong mutations...

Author: fratzinger

test/make-find-mixin.test.ts

@@ -30,7 +30,7 @@ function makeContext() {
 Vue.use(Vuex)
 Vue.use(FeathersVuex)
 
-describe('Find Mixin', function() {
+describe('Find Mixin', function () {
   const { makeServicePlugin, FindModel } = makeContext()
   const serviceName = 'todos'
   const store = new Vuex.Store({
@@ -42,7 +42,7 @@ describe('Find Mixin', function() {
     ]
   })
 
-  it('correctly forms mixin data', function() {
+  it('correctly forms mixin data', function () {
     const todosMixin = makeFindMixin({ service: 'todos' })
     interface TodosComponent {
       todos: []
@@ -99,7 +99,7 @@ describe('Find Mixin', function() {
     )
   })
 
-  it('correctly forms mixin data for dynamic service', function() {
+  it('correctly forms mixin data for dynamic service', function () {
     const tasksMixin = makeFindMixin({
       service() {
         return this.serviceName

test/service-module/make-service-plugin.test.ts

@@ -16,7 +16,7 @@ import _omit from 'lodash/omit'
 
 Vue.use(Vuex)
 
-describe('makeServicePlugin', function() {
+describe('makeServicePlugin', function () {
   beforeEach(() => {
     clearModels()
   })
@@ -28,29 +28,30 @@ describe('makeServicePlugin', function() {
     assert(clients.byAlias['this is a test'], 'got a reference to the client.')
   })
 
-  it('registers the vuex module with options', function() {
+  it('registers the vuex module with options', function () {
     interface RootState {
       todos: {}
     }
 
-    const serverAlias = 'default'
+    const serverAlias = 'make-service-plugin'
     const { makeServicePlugin, BaseModel } = feathersVuex(feathers, {
       serverAlias
     })
-    const servicePath = 'todos'
+    const servicePath = 'make-service-plugin-todos'
     class Todo extends BaseModel {
       public static modelName = 'Todo'
       public static servicePath = servicePath
     }
     const todosPlugin = makeServicePlugin({
       servicePath,
       Model: Todo,
-      service: feathers.service(servicePath)
+      service: feathers.service(servicePath),
+      namespace: 'make-service-plugin-todos'
     })
     const store = new Vuex.Store<RootState>({ plugins: [todosPlugin] })
 
-    const keys = Object.keys(store.state.todos)
-    const received = _pick(store.state.todos, keys)
+    const keys = Object.keys(store.state['make-service-plugin-todos'])
+    const received = _pick(store.state['make-service-plugin-todos'], keys)
     const expected = {
       addOnUpsert: false,
       autoRemove: false,
@@ -76,16 +77,16 @@ describe('makeServicePlugin', function() {
       keyedById: {},
       modelName: 'Todo',
       nameStyle: 'short',
-      namespace: 'todos',
+      namespace: 'make-service-plugin-todos',
       pagination: {
         defaultLimit: null,
         defaultSkip: null
       },
       paramsForServer: ['$populateParams'],
       preferUpdate: false,
       replaceItems: false,
-      serverAlias: 'default',
-      servicePath: 'todos',
+      serverAlias: 'make-service-plugin',
+      servicePath: 'make-service-plugin-todos',
       skipRequestIfExists: false,
       tempsById: {},
       whitelist: []
@@ -94,13 +95,13 @@ describe('makeServicePlugin', function() {
     assert.deepEqual(_omit(received), _omit(expected), 'defaults in place.')
   })
 
-  it('sets up Model.store && service.FeathersVuexModel', function() {
-    const serverAlias = 'default'
+  it('sets up Model.store && service.FeathersVuexModel', function () {
+    const serverAlias = 'make-service-plugin'
     const { makeServicePlugin, BaseModel } = feathersVuex(feathers, {
       serverAlias
     })
 
-    const servicePath = 'todos'
+    const servicePath = 'make-service-plugin-todos'
     const service = feathers.service(servicePath)
     class Todo extends BaseModel {
       public static modelName = 'Todo'
@@ -114,14 +115,14 @@ describe('makeServicePlugin', function() {
     assert.equal(service.FeathersVuexModel, Todo, 'Model accessible on service')
   })
 
-  it('allows accessing other models', function() {
-    const serverAlias = 'default'
+  it('allows accessing other models', function () {
+    const serverAlias = 'make-service-plugin'
     const { makeServicePlugin, BaseModel, models } = feathersVuex(feathers, {
       idField: '_id',
       serverAlias
     })
 
-    const servicePath = 'todos'
+    const servicePath = 'make-service-plugin-todos'
     class Todo extends BaseModel {
       public static modelName = 'Todo'
       public static servicePath = servicePath
@@ -140,18 +141,19 @@ describe('makeServicePlugin', function() {
     assert(Todo.store === store)
   })
 
-  it('allows service specific handleEvents', async function() {
+  it('allows service specific handleEvents', async function () {
     // feathers.use('todos', new TodosService())
-    const serverAlias = 'default'
+    const serverAlias = 'make-service-plugin'
     const { makeServicePlugin, BaseModel } = feathersVuex(feathers, {
       idField: '_id',
       serverAlias
     })
 
-    const servicePath = 'todos'
+    const servicePath = 'make-service-plugin-todos'
     class Todo extends BaseModel {
       public static modelName = 'Todo'
       public static servicePath = servicePath
+      public static namespace = 'make-service-plugin-todos'
     }
 
     let createdCalled = false
@@ -189,7 +191,7 @@ describe('makeServicePlugin', function() {
     const todo = new Todo()
 
     // Fake server call
-    feathers.service('todos').hooks({
+    feathers.service('make-service-plugin-todos').hooks({
       before: {
         create: [
           context => {
@@ -235,9 +237,9 @@ describe('makeServicePlugin', function() {
     assert(removedCalled, 'removed handler called')
   })
 
-  it('fall back to globalOptions handleEvents if service specific handleEvents handler is missing', async function() {
+  it('fall back to globalOptions handleEvents if service specific handleEvents handler is missing', async function () {
     // feathers.use('todos', new TodosService())
-    const serverAlias = 'default'
+    const serverAlias = 'make-service-plugin'
 
     let globalCreatedCalled = false
     let globalUpdatedCalled = false
@@ -266,17 +268,19 @@ describe('makeServicePlugin', function() {
       }
     })
 
-    const servicePath = 'todos'
+    const servicePath = 'make-service-plugin-todos'
     class Todo extends BaseModel {
       public static modelName = 'Todo'
       public static servicePath = servicePath
+      public static namespace = 'make-service-plugin-todos'
     }
 
     let specificUpdatedCalled = false
     const todosPlugin = makeServicePlugin({
       servicePath,
       Model: Todo,
       service: feathers.service(servicePath),
+      namespace: 'make-service-plugin-todos',
       handleEvents: {
         updated() {
           specificUpdatedCalled = true
@@ -292,7 +296,7 @@ describe('makeServicePlugin', function() {
     const todo = new Todo()
 
     // Fake server call
-    feathers.service('todos').hooks({
+    feathers.service('make-service-plugin-todos').hooks({
       before: {
         create: [
           context => {
@@ -339,8 +343,8 @@ describe('makeServicePlugin', function() {
     assert(globalRemovedCalled, 'global removed handler called')
   })
 
-  it('allow handleEvents handlers to return extracted event data', async function() {
-    const serverAlias = 'default'
+  it('allow handleEvents handlers to return extracted event data', async function () {
+    const serverAlias = 'make-service-plugin'
 
     const { makeServicePlugin, BaseModel } = feathersVuex(feathers, {
       idField: '_id',
@@ -361,7 +365,7 @@ describe('makeServicePlugin', function() {
       }
     })
 
-    const servicePath = 'todos'
+    const servicePath = 'make-service-plugin-todos'
     class Todo extends BaseModel {
       public static modelName = 'Todo'
       public static servicePath = servicePath
@@ -371,13 +375,14 @@ describe('makeServicePlugin', function() {
     const todosPlugin = makeServicePlugin({
       servicePath,
       Model: Todo,
-      service: todosService
+      service: todosService,
+      namespace: 'make-service-plugin-todos'
     })
 
     const store = new Vuex.Store<{ todos: ServiceState }>({
       plugins: [todosPlugin]
     })
-    const { keyedById } = store.state.todos
+    const { keyedById } = store.state['make-service-plugin-todos']
 
     let createdData = null
     let updatedData = null

test/service-module/model-base.test.ts

@@ -18,8 +18,8 @@ Vue.use(Vuex)
 process.setMaxListeners(100)
 
 describe.skip('Model - Standalone', function () {
-  it.skip('allows using a model without a service', function () { })
-  it.skip('rename serverAlias to just `alias` or maybe `groupName`', function () { })
+  it.skip('allows using a model without a service', function () {})
+  it.skip('rename serverAlias to just `alias` or maybe `groupName`', function () {})
 })
 
 describe('makeModel / BaseModel', function () {
@@ -28,7 +28,7 @@ describe('makeModel / BaseModel', function () {
   })
 
   it('properly sets up the BaseModel', function () {
-    const alias = 'default'
+    const alias = 'model-base'
     const { BaseModel } = feathersVuex(feathers, { serverAlias: alias })
     const {
       name,
@@ -51,7 +51,7 @@ describe('makeModel / BaseModel', function () {
     assert(!preferUpdate, 'prefer fetch by default')
 
     // Readonly props
-    assert(serverAlias === 'default', 'serverAlias')
+    assert(serverAlias === 'model-base', 'serverAlias')
     assert(models, 'models are available')
     assert.equal(Object.keys(copiesById).length, 0, 'copiesById is empty')
 
@@ -88,14 +88,9 @@ describe('makeModel / BaseModel', function () {
     })
 
     // Utility Methods
-    const utilityMethods = [
-      'hydrateAll'
-    ]
+    const utilityMethods = ['hydrateAll']
     utilityMethods.forEach(method => {
-      assert(
-        typeof BaseModel[method] === 'function',
-        `has ${method} method`
-      )
+      assert(typeof BaseModel[method] === 'function', `has ${method} method`)
     })
 
     const eventMethods = [
@@ -108,10 +103,7 @@ describe('makeModel / BaseModel', function () {
       'removeAllListeners'
     ]
     eventMethods.forEach(method => {
-      assert(
-        typeof BaseModel[method] === 'function',
-        `has ${method} method`
-      )
+      assert(typeof BaseModel[method] === 'function', `has ${method} method`)
     })
   })
 
@@ -149,7 +141,7 @@ describe('makeModel / BaseModel', function () {
   })
 
   it('allows access to other models after Vuex plugins are registered', function () {
-    const serverAlias = 'default'
+    const serverAlias = 'model-base'
     const { makeServicePlugin, BaseModel, models } = feathersVuex(feathers, {
       idField: '_id',
       serverAlias
@@ -158,7 +150,7 @@ describe('makeModel / BaseModel', function () {
     // Create a Todo Model & Plugin
     class Todo extends BaseModel {
       public static modelName = 'Todo'
-      public test: boolean = true
+      public test = true
     }
     const todosPlugin = makeServicePlugin({
       servicePath: 'todos',
@@ -169,7 +161,7 @@ describe('makeModel / BaseModel', function () {
     // Create a Task Model & Plugin
     class Task extends BaseModel {
       public static modelName = 'Task'
-      public test: boolean = true
+      public test = true
     }
     const tasksPlugin = makeServicePlugin({
       servicePath: 'tasks',
@@ -196,7 +188,7 @@ describe('makeModel / BaseModel', function () {
     })
     class Todo extends myApi.BaseModel {
       public static modelName = 'Todo'
-      public test: boolean = true
+      public test = true
     }
     const todosPlugin = myApi.makeServicePlugin({
       Model: Todo,
@@ -210,7 +202,7 @@ describe('makeModel / BaseModel', function () {
     })
     class Task extends theirApi.BaseModel {
       public static modelName = 'Task'
-      public test: boolean = true
+      public test = true
     }
     const tasksPlugin = theirApi.makeServicePlugin({
       Model: Task,