addItems mutation fix tempId

fratzinger · web-flow · commit a0794c07763b · 2019-09-05T13:23:18.000+02:00
If `tempId` was assigned before calling `addItems`-mutation -&gt; `tempId` is undefined -&gt; `newTempsById[undefined] = item`
diff --git a/src/service-module/service-module.mutations.ts b/src/service-module/service-module.mutations.ts
@@ -40,8 +40,9 @@ export default function makeServiceMutations() {
       }
 
       if (isTemp) {
-        if (!item[tempIdField]) {
-          var tempId = assignTempId(state, item)
+        let tempId = item[tempIdField];
+        if (!tempId) {
+          tempId = assignTempId(state, item)
         }
         item.__isTemp = true
         newTempsById[tempId] = item

Original file line number	Diff line number	Diff line change
`@@ -40,8 +40,9 @@ export default function makeServiceMutations() {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`if (isTemp) {`
`43`		`- if (!item[tempIdField]) {`
`44`		`- var tempId = assignTempId(state, item)`
	`43`	`+ let tempId = item[tempIdField];`
	`44`	`+ if (!tempId) {`
	`45`	`+ tempId = assignTempId(state, item)`
`45`	`46`	`}`
`46`	`47`	`item.__isTemp = true`
`47`	`48`	`newTempsById[tempId] = item`