fix: add temp's id to ids in updateTemp #489

Author: hamiltoes

src/service-module/service-module.mutations.ts

@@ -151,6 +151,10 @@ export default function makeServiceMutations() {
         // If an item already exists in the store from the `created` event firing
         // it will be replaced here
         Vue.set(state.keyedById, id, temp)
+        // Only add the id if it's not already in the `ids` list.
+        if (!state.ids.includes(id)) {
+          state.ids.push(id)
+        }
       }
 
       // Add _id to temp's clone as well if it exists

test/service-module/model-temp-ids.test.ts

@@ -431,6 +431,7 @@ describe('Models - Temp Ids', function() {
     store.commit('things/updateTemp', { id: 42, tempId: thing.__id })
     assert(thing._id === 42, 'thing got _id')
     assert(store.state.things.keyedById[42] === thing, 'thing is in keyedById')
+    assert(store.state.things.ids.includes(42), "thing's _id is in ids")
     assert(
       !store.state.things.tempsById[thing.__id],
       'thing is no longer in tempsById'

test/service-module/types.ts

@@ -5,7 +5,7 @@ eslint
 */
 export interface ServiceState {
   options: {}
-  ids: string[]
+  ids: (string | number)[]
   autoRemove: boolean
   errorOnFind: any
   errorOnGet: any