add service tests for count getter/action

Author: fratzinger

test/service-module/model-methods.test.ts

@@ -129,18 +129,18 @@ function makeContext() {
 
 export { makeContext }
 
-describe('Models - Methods', function() {
+describe('Models - Methods', function () {
   beforeEach(() => {
     clearModels()
   })
 
-  it('Model.find is a function', function() {
+  it('Model.find is a function', function () {
     const { Task } = makeContext()
 
     assert(typeof Task.find === 'function')
   })
 
-  it('Model.find returns a Promise', function() {
+  it('Model.find returns a Promise', function () {
     const { Task } = makeContext()
     const result = Task.find()
     assert(typeof result.then !== 'undefined')
@@ -149,46 +149,46 @@ describe('Models - Methods', function() {
     })
   })
 
-  it('Model.findInStore', function() {
+  it('Model.findInStore', function () {
     const { Task } = makeContext()
 
     assert(typeof Task.findInStore === 'function')
   })
 
-  it('Model.count is a function', function() {
+  it('Model.count is a function', function () {
     const { Task } = makeContext()
 
     assert(typeof Task.count === 'function')
   })
 
-  it('Model.count returns a Promise', function() {
+  it('Model.count returns a Promise', function () {
     const { Task } = makeContext()
-    const result = Task.count()
+    const result = Task.count({ query: {} })
     assert(typeof result.then !== 'undefined')
     result.catch(err => {
       /* noop -- prevents UnhandledPromiseRejectionWarning */
     })
   })
 
-  it('Model.countInStore', function() {
+  it('Model.countInStore', function () {
     const { Task } = makeContext()
 
     assert(typeof Task.countInStore === 'function')
   })
 
-  it('Model.get', function() {
+  it('Model.get', function () {
     const { Task } = makeContext()
 
     assert(typeof Task.get === 'function')
   })
 
-  it('Model.getFromStore', function() {
+  it('Model.getFromStore', function () {
     const { Task } = makeContext()
 
     assert(typeof Task.getFromStore === 'function')
   })
 
-  it('allows listening to Feathers events on Model', function(done) {
+  it('allows listening to Feathers events on Model', function (done) {
     const { Letter } = makeContext()
 
     Letter.on('created', data => {
@@ -203,7 +203,7 @@ describe('Models - Methods', function() {
     }).save()
   })
 
-  it('instance.save calls create with correct arguments', function() {
+  it('instance.save calls create with correct arguments', function () {
     const { Task } = makeContext()
     const task = new Task({ test: true })
 
@@ -220,7 +220,7 @@ describe('Models - Methods', function() {
     task.save()
   })
 
-  it('instance.save passes params to create', function() {
+  it('instance.save passes params to create', function () {
     const { Task } = makeContext()
     const task = new Task({ test: true })
     let called = false
@@ -237,7 +237,7 @@ describe('Models - Methods', function() {
     assert(called, 'create should have been called')
   })
 
-  it('instance.save passes params to patch', function() {
+  it('instance.save passes params to patch', function () {
     const { Todo } = makeContext()
     const todo = new Todo({ id: 1, test: true })
     let called = false
@@ -254,7 +254,7 @@ describe('Models - Methods', function() {
     assert(called, 'patch should have been called')
   })
 
-  it('instance.save passes params to update', function() {
+  it('instance.save passes params to update', function () {
     const { Task } = makeContext()
     Task.preferUpdate = true
 
@@ -273,7 +273,7 @@ describe('Models - Methods', function() {
     assert(called, 'update should have been called')
   })
 
-  it('instance.remove works with temp records', function() {
+  it('instance.remove works with temp records', function () {
     const { Task, store } = makeContext()
     const task = new Task({ test: true })
     const tempId = task.__id
@@ -284,11 +284,11 @@ describe('Models - Methods', function() {
     assert(!store.state.tasks.tempsById[tempId], 'temp was removed')
   })
 
-  it.skip('instance.remove removes cloned records from the store', function() {})
-  it.skip('instance.remove removes cloned records from the Model.copiesById', function() {})
-  it.skip('removes clone and original upon calling clone.remove()', function() {})
+  it.skip('instance.remove removes cloned records from the store', function () {})
+  it.skip('instance.remove removes cloned records from the Model.copiesById', function () {})
+  it.skip('removes clone and original upon calling clone.remove()', function () {})
 
-  it('instance methods still available in store data after updateItem mutation (or socket event)', async function() {
+  it('instance methods still available in store data after updateItem mutation (or socket event)', async function () {
     const { Letter, store, lettersService } = makeContext()
     let letter = new Letter({ name: 'Garmadon', age: 1025 })
 
@@ -319,7 +319,7 @@ describe('Models - Methods', function() {
     )
   })
 
-  it('Dates remain as dates after changes', async function() {
+  it('Dates remain as dates after changes', async function () {
     const { Letter, store, lettersService } = makeContext()
     let letter = new Letter({
       name: 'Garmadon',
@@ -336,7 +336,7 @@ describe('Models - Methods', function() {
     assert(isDate(letter.createdAt), 'createdAt should be a date')
   })
 
-  it('instance.toJSON', function() {
+  it('instance.toJSON', function () {
     const { Task } = makeContext()
     const task = new Task({ id: 1, test: true })
 

test/service-module/module.getters.test.ts

@@ -21,11 +21,11 @@ const options = {
   service: null
 }
 
-const { find, list, get, getCopyById } = makeServiceGetters()
+const { find, count, list, get, getCopyById } = makeServiceGetters()
 const { addItems } = makeServiceMutations()
 
-describe('Service Module - Getters', function() {
-  beforeEach(function() {
+describe('Service Module - Getters', function () {
+  beforeEach(function () {
     const state = makeServiceState(options)
     this.items = [
       {
@@ -63,7 +63,7 @@ describe('Service Module - Getters', function() {
     this.state = state
   })
 
-  it('list', function() {
+  it('list', function () {
     const { state, items } = this
     const results = list(state)
 
@@ -74,7 +74,7 @@ describe('Service Module - Getters', function() {
     })
   })
 
-  it('getCopyById with keepCopiesInStore: true', function() {
+  it('getCopyById with keepCopiesInStore: true', function () {
     const state = {
       keepCopiesInStore: true,
       copiesById: {
@@ -88,7 +88,7 @@ describe('Service Module - Getters', function() {
     assert(result.test, 'got the copy')
   })
 
-  it('getCopyById with keepCopiesInStore: false', function() {
+  it('getCopyById with keepCopiesInStore: false', function () {
     const state = {
       keepCopiesInStore: false,
       servicePath: 'todos',
@@ -117,7 +117,7 @@ describe('Service Module - Getters', function() {
     clearModels()
   })
 
-  it('get works on keyedById', function() {
+  it('get works on keyedById', function () {
     const { state, items } = this
     // @ts-ignore
     const result = get(state)(1)
@@ -126,7 +126,7 @@ describe('Service Module - Getters', function() {
     assert.deepEqual(result, items[0])
   })
 
-  it('get works on tempsById', function() {
+  it('get works on tempsById', function () {
     const { state } = this
     const tempId = Object.keys(state.tempsById)[0]
     // @ts-ignore
@@ -136,7 +136,7 @@ describe('Service Module - Getters', function() {
     assert(result.__id === tempId)
   })
 
-  it('find - no temps by default', function() {
+  it('find - no temps by default', function () {
     const { state, items } = this
     const params = { query: {} }
     const results = find(state)(params)
@@ -151,7 +151,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 3, 'total was correct')
   })
 
-  it('find with temps', function() {
+  it('find with temps', function () {
     const { state, items } = this
     // Set temps: false to skip the temps.
     const params = { query: {}, temps: true }
@@ -163,7 +163,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 4, 'total was correct')
   })
 
-  it('find with query', function() {
+  it('find with query', function () {
     const { state } = this
     const params = { query: { test: false } }
     const results = find(state)(params)
@@ -175,7 +175,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 1, 'total was correct')
   })
 
-  it('find with custom operator', function() {
+  it('find with custom operator', function () {
     const { state } = this
     const params = { query: { test: false, $populateQuery: 'test' } }
     const results = find(state)(params)
@@ -187,7 +187,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 1, 'total was correct')
   })
 
-  it('find with paramsForServer option', function() {
+  it('find with paramsForServer option', function () {
     const { state } = this
     state.paramsForServer = ['_$client']
     const params = { query: { test: false, _$client: 'test' } }
@@ -200,7 +200,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 1, 'total was correct')
   })
 
-  it('find with non-whitelisted custom operator fails', function() {
+  it('find with non-whitelisted custom operator fails', function () {
     const { state } = this
     const params = { query: { $client: 'test' } }
     let results
@@ -212,7 +212,7 @@ describe('Service Module - Getters', function() {
     assert(!results[0])
   })
 
-  it('find with whitelisted custom operators', function() {
+  it('find with whitelisted custom operators', function () {
     const { state } = this
     state.whitelist = ['$regex', '$options']
     const query = {
@@ -232,7 +232,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 1, 'total was correct')
   })
 
-  it('find works with $elemMatch', function() {
+  it('find works with $elemMatch', function () {
     const { state } = this
     const query = {
       movies: {
@@ -249,7 +249,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 1, 'total was correct')
   })
 
-  it('find with limit', function() {
+  it('find with limit', function () {
     const { state } = this
     const params = { query: { $limit: 1 } }
     const results = find(state)(params)
@@ -261,7 +261,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 3, 'total was correct')
   })
 
-  it('find with skip', function() {
+  it('find with skip', function () {
     const { state } = this
     const params = { query: { $skip: 1 } }
     const results = find(state)(params)
@@ -274,7 +274,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 3, 'total was correct')
   })
 
-  it('find with limit and skip', function() {
+  it('find with limit and skip', function () {
     const { state } = this
     const params = { query: { $limit: 1, $skip: 1 } }
     const results = find(state)(params)
@@ -286,7 +286,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 3, 'total was correct')
   })
 
-  it('find with select', function() {
+  it('find with select', function () {
     const { state } = this
     const params = { query: { $select: ['otherField'] } }
     const results = find(state)(params)
@@ -305,7 +305,7 @@ describe('Service Module - Getters', function() {
     assert(results.total === 3, 'total was correct')
   })
 
-  it('find with sort ascending on integers', function() {
+  it('find with sort ascending on integers', function () {
     const { state } = this
     const params = {
       query: {
@@ -322,7 +322,7 @@ describe('Service Module - Getters', function() {
       }, 0)
   })
 
-  it('find with sort descending on integers', function() {
+  it('find with sort descending on integers', function () {
     const { state } = this
     const params = {
       query: {
@@ -339,7 +339,7 @@ describe('Service Module - Getters', function() {
       }, 100)
   })
 
-  it('find with sort ascending on floats', function() {
+  it('find with sort ascending on floats', function () {
     const { state } = this
     const params = {
       query: {
@@ -359,7 +359,7 @@ describe('Service Module - Getters', function() {
       }, 0)
   })
 
-  it('find with sort descending on floats', function() {
+  it('find with sort descending on floats', function () {
     const { state } = this
     const params = {
       query: {
@@ -378,4 +378,31 @@ describe('Service Module - Getters', function() {
         return current
       }, 100)
   })
+
+  it('count without params fails', function () {
+    const { state } = this
+
+    try {
+      count(state, { find })(null)
+    } catch (error) {
+      assert(error)
+    }
+  })
+
+  it('count without query fails', function () {
+    const { state } = this
+
+    try {
+      count(state, { find })({})
+    } catch (error) {
+      assert(error)
+    }
+  })
+
+  it('count returns the number of records in the store', function () {
+    const { state } = this
+
+    const total = count(state, { find })({ query: {} })
+    assert(total === 3, 'count is 3')
+  })
 })