Skip to content

Commit cd257ab

Browse files
Merge pull request #562 from sebastien-prudhomme/replace-all
Replace all hyphen characters
2 parents a3e2a6f + e7d36de commit cd257ab

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

src/make-find-mixin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ export default function makeFindMixin(options) {
4545
name = 'service'
4646
}
4747

48-
const nameToUse = (name || service).replace('-', '_')
48+
const nameToUse = (name || service).replace(/-/g, '_')
4949
const prefix = getServicePrefix(nameToUse)
5050
const capitalized = getServiceCapitalization(nameToUse)
5151
const SERVICE_NAME = `${prefix}ServiceName`

src/make-get-mixin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export default function makeFindMixin(options) {
3838
name = 'service'
3939
}
4040

41-
const nameToUse = (name || service).replace('-', '_')
41+
const nameToUse = (name || service).replace(/-/g, '_')
4242
const singularized = inflection.singularize(nameToUse)
4343
const prefix = inflection.camelize(singularized, true)
4444
const capitalized = prefix.charAt(0).toUpperCase() + prefix.slice(1)

src/utils.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ export function getServicePrefix(servicePath) {
274274
const parts = servicePath.split('/')
275275
let name = parts[parts.length - 1]
276276
// name = inflection.underscore(name)
277-
name = name.replace('-', '_')
277+
name = name.replace(/-/g, '_')
278278
name = inflection.camelize(name, true)
279279
return name
280280
}
@@ -283,7 +283,7 @@ export function getServiceCapitalization(servicePath) {
283283
const parts = servicePath.split('/')
284284
let name = parts[parts.length - 1]
285285
// name = inflection.underscore(name)
286-
name = name.replace('-', '_')
286+
name = name.replace(/-/g, '_')
287287
name = inflection.camelize(name)
288288
return name
289289
}

test/utils.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,8 @@ describe('Utils', function () {
162162
['environment-Panos', 'environmentPanos'],
163163
['env-panos', 'envPanos'],
164164
['envPanos', 'envPanos'],
165-
['api/v1/env-panos', 'envPanos']
165+
['api/v1/env-panos', 'envPanos'],
166+
['very-long-service', 'veryLongService']
166167
]
167168
decisionTable.forEach(([path, prefix]) => {
168169
assert(
@@ -181,7 +182,8 @@ describe('Utils', function () {
181182
['environment-Panos', 'EnvironmentPanos'],
182183
['env-panos', 'EnvPanos'],
183184
['envPanos', 'EnvPanos'],
184-
['api/v1/env-panos', 'EnvPanos']
185+
['api/v1/env-panos', 'EnvPanos'],
186+
['very-long-service', 'VeryLongService']
185187
]
186188
decisionTable.forEach(([path, prefix]) => {
187189
assert(

0 commit comments

Comments
 (0)