performance: replace concat with push

fratzinger · fratzinger · commit dda115c6b83e · 2020-10-04T13:27:46.000+02:00
- concat is slow compared to .push(...arr)
diff --git a/src/service-module/service-module.getters.ts b/src/service-module/service-module.getters.ts
@@ -57,7 +57,7 @@ export default function makeServiceGetters() {
       let values = _.values(keyedById)
 
       if (params.temps) {
-        values = values.concat(_.values(state.tempsById))
+        values.push(..._.values(state.tempsById))
       }
 
       values = values.filter(sift(query))

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ export default function makeServiceGetters() {`
`57`	`57`	`let values = _.values(keyedById)`
`58`	`58`
`59`	`59`	`if (params.temps) {`
`60`		`- values = values.concat(_.values(state.tempsById))`
	`60`	`+ values.push(..._.values(state.tempsById))`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`values = values.filter(sift(query))`