Assure that dates on instances remain as dates

This makes sure that setupInstance is called after create and patch or update

Author: marshallswain

package.json

@@ -145,6 +145,7 @@
     "body-parser": "^1.18.3",
     "can-fixture-socket": "^2.0.0",
     "chai": "^4.2.0",
+    "date-fns": "^2.0.0-beta.2",
     "deep-object-diff": "^1.1.0",
     "eslint": "^5.16.0",
     "eslint-config-prettier": "^4.1.0",

test/service-module/model-methods.test.ts

@@ -11,6 +11,7 @@ import Vuex from 'vuex'
 import { clearModels } from '../../src/service-module/global-models'
 import memory from 'feathers-memory'
 import { makeStore } from '../test-utils'
+import { isDate } from 'date-fns'
 
 require('events').EventEmitter.prototype._maxListeners = 100
 
@@ -86,6 +87,12 @@ function makeContext() {
         from: ''
       }
     }
+    public static setupInstance(data, { models }) {
+      if (typeof data.createdAt === 'string') {
+        data.createdAt = new Date(data.createdAt) // just assuming the date is formatted correctly ;)
+      }
+      return data
+    }
     public get status() {
       return 'pending'
     }
@@ -247,6 +254,19 @@ describe('Models - Methods', function () {
     assert.equal(typeof letter2.save, 'function', 'new instance has a save method')
   })
 
+  it('Dates remain as dates after changes', async function () {
+    const { Letter, store, lettersService } = makeContext()
+    let letter = new Letter({ name: 'Garmadon', age: 1025, createdAt: new Date().toString() })
+
+    assert(isDate(letter.createdAt), 'createdAt should be a date')
+
+    letter = await letter.save()
+    assert(isDate(letter.createdAt), 'createdAt should be a date')
+
+    letter = await letter.save()
+    assert(isDate(letter.createdAt), 'createdAt should be a date')
+  })
+
   it('instance.toJSON', function () {
     const { Task } = makeContext()
     const task = new Task({ id: 1, test: true })

yarn.lock

@@ -3781,6 +3781,11 @@ data-urls@^1.1.0:
     whatwg-mimetype "^2.2.0"
     whatwg-url "^7.0.0"
 
+date-fns@^2.0.0-beta.2:
+  version "2.0.0-beta.2"
+  resolved "https://registry.yarnpkg.com/date-fns/-/date-fns-2.0.0-beta.2.tgz#ccd556df832ef761baa88c600f53d2e829245999"
+  integrity sha512-4cicZF707RNerr3/Q3CcdLo+3OHMCfrRXE7h5iFgn7AMvX07sqKLxSf8Yp+WJW5bvKr2cy9/PkctXLv4iFtOaA==
+
 date-now@^0.1.4:
   version "0.1.4"
   resolved "https://registry.yarnpkg.com/date-now/-/date-now-0.1.4.tgz#eaf439fd4d4848ad74e5cc7dbef200672b9e345b"