feat: assert beforeAll all (#7)

* feat: assert beforeAll all

* chore: rm console.log

Author: fratzinger

src/basic.ts

@@ -26,7 +26,7 @@ type TestConfigBasic = Record<AdapterTestNameBasic, () => void | Promise<void>>
 export default (options: BasicTestOptions) => {
   const { test, app, serviceName, idProp } = options
 
-  describe('Basic Functionality', () => {
+  describe('Basic', () => {
     let service: any
 
     beforeEach(() => {

src/index.ts

@@ -5,7 +5,7 @@ import type { AdapterTestNameMethods } from './methods.js'
 import methodTests from './methods.js'
 import type { AdapterTestNameSyntax } from './syntax.js'
 import syntaxTests from './syntax.js'
-import { describe, it, afterAll } from 'vitest'
+import { describe, it } from 'vitest'
 
 export type TestSuiteOptions = {
   app: Application
@@ -32,9 +32,6 @@ export const defineTestSuite = (defineOptions?: DefineTestSuiteOptions) => {
   return (options: TestSuiteOptions) => {
     const { app, serviceName, idProp = 'id' } = options
 
-    const skippedTests: AdapterTestName[] = []
-    const allTests: AdapterTestName[] = []
-
     const test = (name: string, runner: any) => {
       let skip = false
       if (defineOptions?.blacklist?.includes(name as AdapterTestName)) {
@@ -46,25 +43,60 @@ export const defineTestSuite = (defineOptions?: DefineTestSuiteOptions) => {
       ) {
         skip = true
       }
-      const its = skip ? it.skip : it
+      const maybeSkip = skip ? it.skip : it
 
-      if (skip) {
-        skippedTests.push(name as AdapterTestName)
-      }
+      maybeSkip(name, runner)
+    }
 
-      allTests.push(name as AdapterTestName)
+    describe(`app.service('${serviceName}') with options.id: '${idProp}'`, () => {
+      beforeAll(async () => {
+        const service = app.service(serviceName)
 
-      its(name, runner)
-    }
+        // test create
+        const doug = await service.create({
+          name: 'Doug',
+          age: 32,
+        })
+
+        assert.ok(
+          doug[idProp] !== null,
+          `simple 'create' failed (no ${idProp}). Before you start to test the adapter make sure simple create works.`,
+        )
+        assert.strictEqual(
+          doug.name,
+          'Doug',
+          "simple 'create' failed (no name). Before you start to test the adapter make sure simple create works.",
+        )
+        assert.strictEqual(
+          doug.age,
+          32,
+          "simple 'create' failed (no age). Before you start to test the adapter make sure simple create works.",
+        )
+
+        // test delete
 
-    describe(`Adapter tests for '${serviceName}' service with '${idProp}' id property`, () => {
-      afterAll(() => {
-        if (skippedTests.length) {
-          console.log(
-            `\nSkipped the following ${skippedTests.length} Feathers adapter test(s) out of ${allTests.length} total:`,
-          )
-          console.log(JSON.stringify(skippedTests, null, '  '))
-        }
+        const items = await service.find({ paginate: false })
+        assert.ok(
+          Array.isArray(items),
+          'find with paginate:false did not return an array. Before you start to test the adapter make sure simple find works.',
+        )
+        assert.strictEqual(
+          items.length,
+          1,
+          'find should return an item. Before you start to test the adapter make sure simple find works.',
+        )
+        assert.ok(
+          idProp in items[0],
+          `'find' should return an item with ${idProp}. Before you start to test the adapter make sure simple find works.`,
+        )
+        await Promise.all(
+          items.map((item: any) => service.remove(item[idProp])),
+        )
+        const itemsAfterRemove = await service.find({ paginate: false })
+        assert.ok(
+          itemsAfterRemove.length === 0,
+          "'remove' does not work. Before you start to test the adapter make sure simple remove works.",
+        )
       })
 
       basicTests({ test, app, serviceName, idProp })

src/methods.ts

@@ -84,50 +84,6 @@ export default (options: MethodTestOptions) => {
 
     beforeAll(async () => {
       service = app.service(serviceName)
-
-      // test create
-      doug = await service.create({
-        name: 'Doug',
-        age: 32,
-      })
-
-      assert.ok(
-        doug[idProp] !== null,
-        `simple 'create' failed (no ${idProp}). Before you start to test the adapter make sure simple create works.`,
-      )
-      assert.strictEqual(
-        doug.name,
-        'Doug',
-        "simple 'create' failed (no name). Before you start to test the adapter make sure simple create works.",
-      )
-      assert.strictEqual(
-        doug.age,
-        32,
-        "simple 'create' failed (no age). Before you start to test the adapter make sure simple create works.",
-      )
-
-      // test delete
-
-      const items = await service.find({ paginate: false })
-      assert.ok(
-        Array.isArray(items),
-        'find with paginate:false did not return an array. Before you start to test the adapter make sure simple find works.',
-      )
-      assert.strictEqual(
-        items.length,
-        1,
-        'find should return an item. Before you start to test the adapter make sure simple find works.',
-      )
-      assert.ok(
-        idProp in items[0],
-        `'find' should return an item with ${idProp}. Before you start to test the adapter make sure simple find works.`,
-      )
-      await Promise.all(items.map((item: any) => service.remove(item[idProp])))
-      const itemsAfterRemove = await service.find({ paginate: false })
-      assert.ok(
-        itemsAfterRemove.length === 0,
-        "'remove' does not work. Before you start to test the adapter make sure simple remove works.",
-      )
     })
 
     beforeEach(async () => {