fix: ensure $select (#8)

* fix: ensure $select

* fix: reset before beforeAll

* fix: update age nullable

Author: fratzinger

src/index.ts

@@ -52,6 +52,16 @@ export const defineTestSuite = (defineOptions?: DefineTestSuiteOptions) => {
       beforeAll(async () => {
         const service = app.service(serviceName)
 
+        let items = await service.find({ paginate: false })
+        assert.ok(
+          Array.isArray(items),
+          'find with paginate:false did not return an array. Before you start to test the adapter make sure simple find works.',
+        )
+
+        await Promise.all(
+          items.map((item: any) => service.remove(item[idProp])),
+        )
+
         // test create
         const doug = await service.create({
           name: 'Doug',
@@ -75,7 +85,7 @@ export const defineTestSuite = (defineOptions?: DefineTestSuiteOptions) => {
 
         // test delete
 
-        const items = await service.find({ paginate: false })
+        items = await service.find({ paginate: false })
         assert.ok(
           Array.isArray(items),
           'find with paginate:false did not return an array. Before you start to test the adapter make sure simple find works.',

src/methods.ts

@@ -130,7 +130,7 @@ export default (options: MethodTestOptions) => {
             `${idProp} id property matches`,
           )
           assert.strictEqual(data.name, 'Doug', 'data.name matches')
-          assert.ok(!data.age, 'data.age is falsy')
+          assert.ok(!('age' in data), 'data.age is not present')
         },
         '.get + id + query': async () => {
           await assert.rejects(
@@ -182,7 +182,7 @@ export default (options: MethodTestOptions) => {
             `${idProp} id property matches`,
           )
           assert.strictEqual(data.name, 'Doug', 'data.name matches')
-          assert.ok(!data.age, 'data.age is falsy')
+          assert.ok(!('age' in data), 'data.age is not presents')
         },
         '.remove + id + query': async () => {
           await assert.rejects(
@@ -341,7 +341,7 @@ export default (options: MethodTestOptions) => {
             `${idProp} id matches`,
           )
           assert.strictEqual(data.name, 'Dougler', 'data.name matches')
-          assert.ok(!data.age, 'data.age is falsy')
+          assert.ok(data.age == null, 'data.age is nullable') // could be null or undefined, based on the adapter
         },
         '.update + $select': async () => {
           const originalData = {
@@ -359,10 +359,12 @@ export default (options: MethodTestOptions) => {
             doug[idProp].toString(),
             `${idProp} id property matches`,
           )
-          assert.strictEqual(data.name, 'Dougler', 'data.name matches')
-          assert.ok(!data.age, 'data.age is falsy')
+          assert.strictEqual(data.name, 'Dougler', 'data.name changed')
+          assert.ok(!('age' in data), 'data.age is not present')
+
+          const changed = await service.get(doug[idProp])
 
-          // TODO: service.get(doug[idProp]) should have age set to 10
+          assert.strictEqual(changed.age, originalData.age, 'data.age changed')
         },
         '.update + id + query': async () => {
           await assert.rejects(
@@ -457,7 +459,11 @@ export default (options: MethodTestOptions) => {
           assert.strictEqual(data.age, 32, 'data.age matches')
         },
         '.patch + $select': async () => {
-          const originalData = { [idProp]: doug[idProp], name: 'PatchDoug' }
+          const originalData = {
+            [idProp]: doug[idProp],
+            name: 'PatchDoug',
+            age: 10,
+          }
 
           const data = await service.patch(doug[idProp], originalData, {
             query: { $select: ['name'] },
@@ -469,9 +475,10 @@ export default (options: MethodTestOptions) => {
             `${idProp} id property matches`,
           )
           assert.strictEqual(data.name, 'PatchDoug', 'data.name matches')
-          assert.ok(!data.age, 'data.age is falsy')
+          assert.ok(!('age' in data), 'data.age is not present')
 
-          // TODO: service.get(doug[idProp]) should have age set to 10
+          const changed = await service.get(doug[idProp])
+          assert.strictEqual(changed.age, originalData.age, 'data.age changed')
         },
         '.patch + id + query': async () => {
           await assert.rejects(
@@ -852,7 +859,7 @@ export default (options: MethodTestOptions) => {
 
           assert.ok(idProp in data, 'data has id')
           assert.strictEqual(data.name, 'William', 'data.name matches')
-          assert.ok(!data.age, 'data.age is falsy')
+          assert.ok(!('age' in data), 'data.age is not present')
 
           const created = await service.get(data[idProp])