Skip to content

Error when passing redisClient and not uri #197

@palmtown

Description

@palmtown

Steps to reproduce

  • Tell us what broke. The more detailed the better.

If passing a redisClient object as shown in Exhibit 1, current code will throw an error as it is expecting the uri. However, when passing the redisClient the uri is not required.

Exhibit 1
app.configure( sync({ redisClient }) );

  • If you can, please create a simple example that reproduces the issue and link to a gist, jsbin, repo, etc.

You can reproduce by configuring feathersjs sync as shown in the Exhibit 1 snipplet above.

Expected behavior

Code should not generate an error when a redisClient object is passed.

Actual behavior

Code throws the error: A uri option with the database connection string, or a redisClient object has to be provided to feathers-sync

I have resolved the issue and created a pull request at: #196

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions