-
|
I do not know if this is an issue . so I made it new Q & A in discussion. The issueI want to add unique validation rule to my validation schema with ajv, typebox and feathersjs v5. this is the code in validators file import { Ajv, addFormats } from "@feathersjs/schema";
import type { FormatsPluginOptions } from "@feathersjs/schema";
import { app } from "./app";
const formats: FormatsPluginOptions = [
"date-time",
"time",
"date",
"email",
"hostname",
"ipv4",
"ipv6",
"uri",
"uri-reference",
"uuid",
"uri-template",
"json-pointer",
"relative-json-pointer",
"regex",
];
let ajv = new Ajv({
allErrors: true,
messages: false,
});
ajv.addKeyword({
keyword: "unique",
type: "string",
async: true,
validate: async (schema: any, data: any) => {
try {
let row = await app
.get("dbclient")
.table(schema.table)
.where(schema.field, data)
.first();
return row !== undefined;
} catch (e) {
return true;
}
},
error: {
message: "out",
},
});
export const dataValidator: Ajv = addFormats(ajv, formats);
export const queryValidator: Ajv = addFormats(
new Ajv({
coerceTypes: true,
}),
formats,
);and when I need to use this with schema for example Type.Object({
name: Type.String({minLength:3, unique: {table: 'users', field: 'name'}})
}, {
$async: true
})I see the next error Info
Notes
The Question : any help with this ?
thank you. |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 4 replies
-
|
When using properties with that keyword in the query validator it needs to be added there as well. const keywordUnique = {
keyword: 'unique',
type: 'string',
async: true,
validate: async (schema: any, data: any) => {
try {
let row = await app.get('dbclient').table(schema.table).where(schema.field, data).first()
return row !== undefined
} catch (e) {
return true
}
},
error: {
message: 'out'
}
} as const
export const dataValidator: Ajv = addFormats(new Ajv({}), formats)
export const queryValidator: Ajv = addFormats(
new Ajv({
coerceTypes: true
}),
formats
)
dataValidator.addKeyword(keywordUnique)
queryValidator.addKeyword(keywordUnique) |
Beta Was this translation helpful? Give feedback.
-
|
Thank you very much. For the answer and the awesome framework |
Beta Was this translation helpful? Give feedback.
-
|
Thank you. Though, thinking about it, the query validator probably shouldn't do unique keyword validation. One way to not have to deal with AJV is either adding a unique constraint to your database or by making it database independent and putting it in a resolver: export const messageDataResolver = resolve<Message, HookContext>({
someField: async (value, data, context) => {
const [existing] = context.service.find({
paginate: false,
query: {
someField: value
}
})
if (existing) {
throw new BadRequest('Value already exists')
}
return value
}
})Which can also be made reusable of course: const unique = (field: string) => async (value: unknown, data: unknown, context: HookContext) => {
const [existing] = context.service.find({
paginate: false,
query: {
[field]: value
}
})
if (existing) {
throw new BadRequest(`Value for ${field} already exists`)
}
return value
}
export const messageDataResolver = resolve<Message, HookContext>({
someField: unique('someField')
}) |
Beta Was this translation helpful? Give feedback.
-
|
You are right. I changed the query schema by not using the schema with unique rule. I used pick with composite . but composite is not present in typebox used by feathers . It is on the newer version. So, I made a new schema as needed. |
Beta Was this translation helpful? Give feedback.
-
|
Before using the schema way, I used some hook. With the same logic in your code. But the ux for end user was not good because the unique error will be shown only after all other schema are fixed. |
Beta Was this translation helpful? Give feedback.
When using properties with that keyword in the query validator it needs to be added there as well.