return list of books under a key

Author: GIG0i

src/http_app/routes/api/books.py

@@ -1,5 +1,7 @@
+from typing import Iterable
+
 from fastapi import APIRouter, status
-from pydantic import BaseModel, RootModel, ConfigDict
+from pydantic import BaseModel, ConfigDict
 
 from domains.books import BookService, dto
 
@@ -20,23 +22,25 @@ class CreateBookResponse(BaseModel):
     )
 
 
-class ListBooksResponse(RootModel):
-    root: list[dto.Book]
+class ListBooksResponse(BaseModel):
+    books: Iterable[dto.Book]
     model_config = ConfigDict(
         json_schema_extra={
-            "example":
-            [
-                {
-                    "title": "The Hitchhiker's Guide to the Galaxy",
-                    "author_name": "Douglas Adams",
-                    "book_id": 123,
-                },
-                {
-                    "title": "Clean Architecture: A Craftsman's Guide to Software Structure and Design",
-                    "author_name": "Robert C. 'Uncle Bob' Martin",
-                    "book_id": 321,
-                },
-            ]
+            "example": {
+                "books": [
+                    {
+                        "title": "The Hitchhiker's Guide to the Galaxy",
+                        "author_name": "Douglas Adams",
+                        "book_id": 123,
+                    },
+                    {
+                        "title": "Clean Architecture: "
+                        "A Craftsman's Guide to Software Structure and Design",
+                        "author_name": "Robert C. 'Uncle Bob' Martin",
+                        "book_id": 321,
+                    },
+                ]
+            }
         }
     )
 
@@ -65,11 +69,12 @@ class CreateBookRequest(BaseModel):
               into the format needed for the proper HTTP Response
 """
 
+
 @router_v1.get("/", status_code=status.HTTP_200_OK)
 async def list_books() -> ListBooksResponse:
     book_service = BookService()
     books = await book_service.list_books()
-    return ListBooksResponse(root=books)
+    return ListBooksResponse(books=books)
 
 
 @router_v1.post("/", status_code=status.HTTP_201_CREATED)

tests/http_app/routes/books/test_list_books.py

@@ -4,10 +4,10 @@
 
 async def test_list_books(testapp):
     ac = TestClient(app=testapp, base_url="http://test")
-    response = ac.get(
-        "/api/books/v1/"
-    )
+    response = ac.get("/api/books/v1/")
     assert response.status_code == status.HTTP_200_OK
-    assert len(response.json()) == 1
-    assert response.json()[0]['title'] == "The Shining"
-    assert response.json()[0]['author_name'] == "Stephen King"
+    body = response.json()
+    assert "books" in body
+    assert len(body["books"]) == 1
+    assert body["books"][0]["title"] == "The Shining"
+    assert body["books"][0]["author_name"] == "Stephen King"