Lint and typing

Author: febus982

src/common/utils.py

@@ -16,9 +16,8 @@ def class_decorator(cls):
                 if not private_methods:
                     continue
 
-            elif attr_name.startswith("_"):
-                if not protected_methods:
-                    continue
+            elif attr_name.startswith("_") and not protected_methods:
+                continue
 
             # Replace the original callable with the decorated version
             setattr(cls, attr_name, decorator(attr_value))

src/domains/books/_service.py

@@ -6,6 +6,7 @@
 
 from common.tracing import trace_function
 from common.utils import apply_decorator_to_methods
+
 from ._gateway_interfaces import BookEventGatewayInterface, BookRepositoryInterface
 from ._models import BookModel
 from ._tasks import book_cpu_intensive_task

tests/common/test_utils.py

@@ -8,15 +8,15 @@
 @pytest.mark.parametrize(
     "apply_to_protected_methods",
     [
-        True,
-        False,
+        pytest.param(True, id="protected_methods"),
+        pytest.param(False, id="no_protected_methods"),
     ],
 )
 @pytest.mark.parametrize(
     "apply_to_private_methods",
     [
-        True,
-        False,
+        pytest.param(True, id="private_methods"),
+        pytest.param(False, id="no_private_methods"),
     ],
 )
 async def test_class_decorator(
@@ -61,7 +61,7 @@ async def __get_aprivate(self):
     c = MyClass()
     assert c.get_public() == 20
     assert c._get_protected() == 20 if apply_to_protected_methods else 10
-    assert c._MyClass__get_private() == 20 if apply_to_private_methods else 10
+    assert c._MyClass__get_private() == 20 if apply_to_private_methods else 10  # type: ignore
     assert await c.get_apublic() == 20
     assert await c._get_aprotected() == 20 if apply_to_protected_methods else 10
-    assert await c._MyClass__get_aprivate() == 20 if apply_to_private_methods else 10
+    assert await c._MyClass__get_aprivate() == 20 if apply_to_private_methods else 10  # type: ignore