Relax dramatiq bootstrap logic

Signed-off-by: Federico Busetti <[email protected]>

Author: febus982

src/common/dramatiq.py

@@ -1,3 +1,5 @@
+import logging
+
 import orjson
 from dramatiq import set_broker, set_encoder
 from dramatiq.broker import Broker
@@ -26,15 +28,17 @@ def decode(self, data: bytes) -> MessageData:
 
 
 def init_dramatiq(config: AppConfig):
-    DramatiqInstrumentor().instrument()
     broker: Broker
-    if config.ENVIRONMENT == "test":
-        broker = StubBroker()
-        # broker.emit_after("process_boot")
-    elif config.DRAMATIQ.REDIS_URL is not None:
+
+    DramatiqInstrumentor().instrument()
+
+    if config.DRAMATIQ.REDIS_URL is not None:
         broker = RedisBroker(url=config.DRAMATIQ.REDIS_URL)
     else:
-        raise RuntimeError("Running a non-test environment without Redis URL set")
+        broker = StubBroker()
+        # broker.emit_after("process_boot")
+        if config.ENVIRONMENT != "test":
+            logging.critical("Running a non-test environment without Redis URL set")
     broker.add_middleware(AsyncIO())
     set_broker(broker)
     set_encoder(ORJSONEncoder())

tests/common/test_dramatiq.py

@@ -1,3 +1,4 @@
+import logging
 from unittest.mock import MagicMock, patch
 
 import orjson
@@ -61,12 +62,12 @@ def test_init_dramatiq_with_redis():
         assert isinstance(get_encoder(), ORJSONEncoder)
 
 
-def test_init_dramatiq_without_redis_url():
+def test_init_dramatiq_without_redis_url(caplog):
     """Test if an exception is raised when in non-test environment without Redis URL."""
     config = AppConfig(
         ENVIRONMENT="production", DRAMATIQ=DramatiqConfig(REDIS_URL=None)
     )  # Mock config
-    with pytest.raises(
-        RuntimeError, match="Running a non-test environment without Redis URL set"
-    ):
+    with caplog.at_level(logging.CRITICAL):
         init_dramatiq(config)
+
+    assert "Running a non-test environment without Redis URL set" in caplog.text

tests/http_app/test_factory.py

@@ -1,18 +1,14 @@
 from unittest.mock import patch
 
-import pytest
-
 from common.config import AppConfig
 from http_app import create_app
 
 
 def test_with_default_config() -> None:
-    """Test create_app fails without passing test config."""
-    with (
-        patch("common.bootstrap.init_storage", return_value=None),
-        pytest.raises(RuntimeError),
-    ):
-        create_app()
+    """Test create_app without passing test config."""
+    with patch("common.bootstrap.init_storage", return_value=None):
+        app = create_app()
+    assert app.debug is False
 
 
 def test_with_debug_config() -> None: