Skip to content

Commit 88eb3f9

Browse files
committed
* Remove duplicate di container initialisation
* Move celery bootstrap in bootstrap module Signed-off-by: Federico Busetti <[email protected]>
1 parent 972f10b commit 88eb3f9

File tree

3 files changed

+12
-20
lines changed

3 files changed

+12
-20
lines changed

src/bootstrap/bootstrap.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
from celery import Celery
22
from dependency_injector.containers import DynamicContainer
33
from dependency_injector.providers import Object
4-
from domains import init_celery, init_domains
54
from pydantic import BaseModel, ConfigDict
65

6+
from .celery import init_celery
77
from .config import AppConfig
88
from .di_container import Container
99
from .logs import init_logger
@@ -22,7 +22,6 @@ def application_init(app_config: AppConfig) -> InitReference:
2222
config=Object(app_config),
2323
)
2424
init_logger(app_config)
25-
init_domains(app_config)
2625
init_storage()
2726
celery = init_celery(app_config)
2827

src/bootstrap/celery.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
from celery import Celery
2+
3+
from .config import AppConfig
4+
5+
6+
def init_celery(config: AppConfig) -> Celery:
7+
celery_app = Celery(f"{config.APP_NAME}-celery")
8+
celery_app.config_from_object(config.CELERY)
9+
celery_app.autodiscover_tasks()
10+
11+
return celery_app

src/domains/__init__.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +0,0 @@
1-
from bootstrap.config import AppConfig
2-
from bootstrap.di_container import Container
3-
from celery import Celery
4-
from dependency_injector.providers import Object
5-
6-
7-
def init_domains(config: AppConfig):
8-
Container(
9-
config=Object(config),
10-
)
11-
12-
13-
def init_celery(config: AppConfig) -> Celery:
14-
celery_app = Celery(f"{config.APP_NAME}-celery")
15-
celery_app.config_from_object(config.CELERY)
16-
celery_app.autodiscover_tasks()
17-
18-
return celery_app

0 commit comments

Comments
 (0)