Remove direct structlog usage

Author: febus982

src/common/logs/__init__.py

@@ -15,11 +15,22 @@
 
 def init_logger(config: AppConfig) -> None:
     """
-    Configure structlog and stdlib logging with shared handler and formatter.
+    Function to initialize logging configuration using `structlog` and Python's standard
+    logging module. It supports dynamic log level adjustment, shared processors for
+    structlog and standard loggers, and tailored configurations for different environments
+    (local, test, or production). Ensures consistent formatting across application logs
+    and integrates handlers for OpenTelemetry logs if present.
+
+    Args:
+        config (AppConfig): Configuration object containing application-wide settings
+        such as DEBUG flag and environment status.
+
+    Raises:
+        None
+
+    Returns:
+        None
 
-    :param config: The app configuration
-    :type config: AppConfig
-    :return:
     """
     # Strongly inspired by https://gist.github.com/nymous/f138c7f06062b7c43c060bf03759c29e
 
@@ -83,10 +94,9 @@ def init_logger(config: AppConfig) -> None:
     # In case there's a OTEL handler we keep it but remove all the others,
     # in case this function is called multiple times.
     # NOTE all the processors are not applied to OTEL logs!
-    for l in stdlib_logger.handlers:
-        if not isinstance(l, LoggingHandler):
-            stdlib_logger.removeHandler(l)
-
+    for handler in stdlib_logger.handlers:
+        if not isinstance(handler, LoggingHandler):
+            stdlib_logger.removeHandler(handler)
 
     # Use structlog to format logs coming from stdlib logger
     stdlib_logger.addHandler(stdlib_handler)

src/domains/books/_service.py

@@ -1,8 +1,8 @@
+import logging
 from collections.abc import Iterable
 
 from anyio import to_thread
 from dependency_injector.wiring import Provide, inject
-from structlog import get_logger
 
 from common.tracing import trace_function
 from common.utils import apply_decorator_to_methods
@@ -58,8 +58,12 @@ async def book_created_event_handler(
         book_id: int,
     ) -> None:  # pragma: no cover
         # This is just an example placeholder, there's nothing to test.
-        logger = get_logger()
-        await logger.ainfo(f"Processed book crated event for id `{book_id}`")
+        logging.info(
+            "Processed book crated event`",
+            extra={
+                "book_id": book_id,
+            },
+        )
 
     def _some_cpu_intensive_blocking_task(self, book: dict) -> dict:
         # This is just an example placeholder,

src/gateways/event.py

@@ -1,11 +1,8 @@
+import logging
+
 from cloudevents_pydantic.events import CloudEvent
-from structlog import get_logger
 
 
 class NullEventGateway:
     async def emit(self, event: CloudEvent) -> None:  # pragma: no cover # No need to test this
-        logger = get_logger()
-        await logger.ainfo(
-            "Event emitted",
-            cloudevent=event.model_dump(),
-        )
+        logging.info("Event emitted", extra={"cloudevent": event.model_dump()})

src/http_app/__init__.py

@@ -1,10 +1,10 @@
+import logging
 from typing import Union
 
 from fastapi import FastAPI, Request
 from opentelemetry.instrumentation.asgi import OpenTelemetryMiddleware
 from starlette.responses import JSONResponse
 from starlette_prometheus import PrometheusMiddleware, metrics
-from structlog import get_logger
 
 from common import AppConfig, application_init
 from http_app import context
@@ -62,6 +62,5 @@ async def add_exception_middleware(request: Request, call_next):
         try:
             return await call_next(request)
         except Exception as e:
-            logger = get_logger(__name__)
-            await logger.aexception(e)
+            logging.exception(e)
             return JSONResponse({"error": "Internal server error"}, status_code=500)

tests/http_app/test_exception_handlers.py

@@ -1,12 +1,12 @@
-from unittest.mock import AsyncMock, MagicMock, patch
+from unittest.mock import MagicMock, patch
 
 from fastapi import FastAPI
 from fastapi.testclient import TestClient
 
 
-@patch("http_app.get_logger")
+@patch("logging.exception")
 async def test_exception_is_logged_handler_returns_500(
-    mocked_get_logger: MagicMock,
+    mocked_logging_exception: MagicMock,
     testapp: FastAPI,
 ):
     my_exc = Exception("Some random exception")
@@ -15,12 +15,9 @@ async def test_exception_is_logged_handler_returns_500(
     async def fake_endpoint():
         raise my_exc
 
-    mocked_get_logger.return_value.aexception = AsyncMock(return_value=None)
-
     ac = TestClient(app=testapp, base_url="http://test")
     response = ac.get("/ppp")
 
     assert response.status_code == 500
     assert response.json() == {"error": "Internal server error"}
-    mocked_get_logger.assert_called_once()
-    mocked_get_logger.return_value.aexception.assert_called_once_with(my_exc)
+    mocked_logging_exception.assert_called_once_with(my_exc)