Use FastAPI instrumentor

Author: febus982

pyproject.toml

@@ -37,10 +37,10 @@ http = [
     "fastapi>=0.99.0",
     "jinja2<4.0.0,>=3.1.2",
     # We use the generic ASGI instrumentation, so that if we decide to change
-    # Framework it will still work consistently.
+    # framework it will still name metrics with a generic naming.
     "opentelemetry-instrumentation-asgi",
+    "opentelemetry-instrumentation-fastapi",
     "pyjwt>=2.10.1",
-    "starlette-prometheus<1.0.0,>=0.10.0",
     "strawberry-graphql[debug-server]>=0.204.0",
     "uvicorn[standard]<1.0.0,>=0.34.0",
 ]

src/http_app/__init__.py

@@ -2,9 +2,7 @@
 from typing import Union
 
 from fastapi import FastAPI, Request
-from opentelemetry.instrumentation.asgi import OpenTelemetryMiddleware
 from starlette.responses import JSONResponse
-from starlette_prometheus import PrometheusMiddleware, metrics
 
 from common import AppConfig, application_init
 from http_app import context
@@ -34,21 +32,6 @@ def create_app(
 
     init_routes(app)
 
-    """
-    OpenTelemetry prometheus exporter does not work together with automatic
-    instrumentation, for now we keep the prometheus middleware even if
-    having 2 different middlewares will add overhead.
-    """
-    app.add_middleware(PrometheusMiddleware)
-    app.add_route("/metrics/", metrics)
-
-    """
-    OpenTelemetry middleware has to be the last one to make sure the
-    tracing data handling is the outermost logic
-    Some typing issues to be addressed in OpenTelemetry but it works.
-    """
-    app.add_middleware(OpenTelemetryMiddleware)  # type: ignore
-
     return app