Split test and build steps (preparation for matrix build)

Author: febus982

.github/workflows/ci-pipeline.yml

@@ -17,8 +17,39 @@ env:
   TEST_TAG: user/app:test
 
 jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      # This might be unnecessary as tests are not
+      # multiplatform
+      - name: Setup Docker buildx
+        uses: docker/[email protected]
+
+      # Build but not push Docker image with Buildx
+      # https://github.com/docker/build-push-action
+      - name: Build test image
+        id: build-test
+        uses: docker/[email protected]
+        with:
+          context: .
+          load: true
+          target: dev
+          tags: ${{ env.TEST_TAG }}
+          cache-from: type=gha
+          cache-to: type=gha,mode=max
+
+      # This is a barrier check to make sure we push a functional
+      # docker image, we can avoid linting
+      - name: Run tests in the test image
+        run: |
+          docker run --rm ${{ env.TEST_TAG }} make ci-test
+
   build:
     runs-on: ubuntu-latest
+    needs: test
     permissions:
       contents: read
       packages: write
@@ -33,15 +64,15 @@ jobs:
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
 
-      # Install the cosign tool except on PR
+      # Install the cosign tool
       # https://github.com/sigstore/cosign-installer
       - name: Install cosign
         uses: sigstore/[email protected]
 
       - name: Setup Docker buildx
         uses: docker/[email protected]
 
-      # Login against a Docker registry except on PR
+      # Login against a Docker registry
       # https://github.com/docker/login-action
       - name: Log into registry ${{ env.REGISTRY }}
         uses: docker/[email protected]
@@ -50,23 +81,6 @@ jobs:
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
-      # Build and push Docker image with Buildx
-      # https://github.com/docker/build-push-action
-      - name: Build test image
-        id: build-test
-        uses: docker/[email protected]
-        with:
-          context: .
-          load: true
-          target: dev
-          tags: ${{ env.TEST_TAG }}
-          cache-from: type=gha
-          cache-to: type=gha,mode=max
-
-      - name: Test
-        run: |
-          docker run --rm ${{ env.TEST_TAG }} make ci-test
-
       # Extract metadata (tags, labels) for Docker
       # https://github.com/docker/metadata-action
       - name: Extract Docker metadata