Makefile improvements

Author: febus982

.github/workflows/python-3.10.yml

@@ -24,7 +24,7 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install poetry
         poetry config virtualenvs.create false
-        poetry install --no-root --with http,grpc,dev
+        make dev-dependencies
     - name: Test with pytest
       run: |
         make ci-test

.github/workflows/python-3.11.yml

@@ -24,7 +24,7 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install poetry
         poetry config virtualenvs.create false
-        poetry install --no-root --with http,grpc,dev
+        make dev-dependencies
     - name: Test with pytest
       run: |
         make ci-test

.github/workflows/python-3.9.yml

@@ -24,7 +24,7 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install poetry
         poetry config virtualenvs.create false
-        poetry install --no-root --with http,grpc,dev
+        make dev-dependencies
     - name: Test with pytest
       run: |
         make ci-test

.github/workflows/python-code-style.yml

@@ -24,7 +24,7 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install poetry
         poetry config virtualenvs.create false
-        poetry install --no-root --with http,grpc,dev
+        make dev-dependencies
     - name: Check code style with black
       run: |
         make format

.github/workflows/python-lint.yml

@@ -24,6 +24,6 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install poetry
         poetry config virtualenvs.create false
-        poetry install --no-root --with http,grpc,dev
+        make dev-dependencies
     - name: Lint with ruff
       run: make lint

.github/workflows/python-quality.yml

@@ -24,7 +24,7 @@ jobs:
         python -m pip install --upgrade pip
         python -m pip install poetry
         poetry config virtualenvs.create false
-        poetry install --no-root --with http,grpc,dev
+        make dev-dependencies
     - name: Test & publish code coverage
       uses: paambaati/[email protected]
       if: env.CC_TEST_REPORTER_ID != null

Dockerfile

@@ -43,7 +43,7 @@ COPY --chown=nonroot:nonroot poetry.lock .
 
 # Test image, contains all files and dependencies
 FROM base_builder as dev
-RUN poetry install --with http,grpc,dev
+RUN make dev-dependencies
 COPY --chown=nonroot:nonroot . .
 # Note that opentelemetry doesn't play well together with uvicorn reloader
 # when signals are propagated, we disable it in dev image default CMD

Makefile

@@ -30,10 +30,13 @@ ci-coverage:
 typing:
 	poetry run mypy
 
-dev-deps:
+install-dependencies:
+	poetry install --no-root --with http,grpc
+
+dev-dependencies:
 	poetry install --no-root --with http,grpc,dev
 
-update-deps:
+update-dependencies:
 	poetry update --with http,grpc,dev
 
 migrate:

README.md

@@ -76,8 +76,9 @@ Using Docker:
 Locally:
 
 * `make migrate`: Run database migrations
-* `make dev-deps`: Install requirements
-* `make update-deps`: Updates requirements
+* `make install-dependencies`: Install requirements
+* `make dev-dependencies`: Install dev requirements
+* `make update-dependencies`: Updates requirements
 * `make migrate`: Run database migrations
 * `make dev`: Run HTTP application with hot reload
 * `make grpc`: Run GRPC application