Remove fixed "type: ignore"

Author: febus982

sqlalchemy_bind_manager/_repository/async_.py

@@ -47,7 +47,7 @@ async def save(self, instance: MODEL) -> MODEL:
         :param instance: A mapped object instance to be persisted
         :return: The model instance after being persisted (e.g. with primary key populated)
         """
-        async with self._get_session() as session:  # type: ignore
+        async with self._get_session() as session:
             session.add(instance)
         return instance
 
@@ -61,7 +61,7 @@ async def save_many(
         :type instances: Iterable
         :return: The model instances after being persisted (e.g. with primary keys populated)
         """
-        async with self._get_session() as session:  # type: ignore
+        async with self._get_session() as session:
             session.add_all(instances)
         return instances
 
@@ -74,7 +74,7 @@ async def get(self, identifier: PRIMARY_KEY) -> MODEL:
         """
         # TODO: implement get_many()
         async with self._get_session(commit=False) as session:
-            model = await session.get(self._model, identifier)  # type: ignore
+            model = await session.get(self._model, identifier)
         if model is None:
             raise ModelNotFound("No rows found for provided primary key.")
         return model
@@ -90,7 +90,7 @@ async def delete(
         """
         # TODO: delete without loading the model
         obj = entity if self._is_mapped_object(entity) else await self.get(entity)  # type: ignore
-        async with self._get_session() as session:  # type: ignore
+        async with self._get_session() as session:
             await session.delete(obj)
 
     async def find(
@@ -108,13 +108,13 @@ async def find(
         :return: A collection of models
         :rtype: List
         """
-        stmt = select(self._model)  # type: ignore
+        stmt = select(self._model)
         if search_params:
             stmt = self._filter_select(stmt, search_params)
 
         if order_by is not None:
             stmt = self._filter_order_by(stmt, order_by)
 
-        async with self._get_session() as session:  # type: ignore
+        async with self._get_session() as session:
             result = await session.execute(stmt)
             return [x for x in result.scalars()]

sqlalchemy_bind_manager/_repository/common.py

@@ -49,7 +49,7 @@ def _validate_mapped_property(self, property_name: str) -> None:
         :raises UnmappedProperty: When the property is not mapped.
         """
         m: Mapper = class_mapper(self._model)
-        if property_name not in m.column_attrs:  # type: ignore
+        if property_name not in m.column_attrs:
             raise UnmappedProperty(
                 f"Property `{property_name}` is not mapped in the ORM for model `{self._model}`"
             )

sqlalchemy_bind_manager/_repository/sync.py

@@ -47,7 +47,7 @@ def save(self, instance: MODEL) -> MODEL:
         :param instance: A mapped object instance to be persisted
         :return: The model instance after being persisted (e.g. with primary key populated)
         """
-        with self._get_session() as session:  # type: ignore
+        with self._get_session() as session:
             session.add(instance)
         return instance
 
@@ -58,7 +58,7 @@ def save_many(self, instances: Iterable[MODEL]) -> Iterable[MODEL]:
         :type instances: Iterable
         :return: The model instances after being persisted (e.g. with primary keys populated)
         """
-        with self._get_session() as session:  # type: ignore
+        with self._get_session() as session:
             session.add_all(instances)
         return instances
 
@@ -71,7 +71,7 @@ def get(self, identifier: PRIMARY_KEY) -> MODEL:
         """
         # TODO: implement get_many()
         with self._get_session(commit=False) as session:
-            model = session.get(self._model, identifier)  # type: ignore
+            model = session.get(self._model, identifier)
         if model is None:
             raise ModelNotFound("No rows found for provided primary key.")
         return model
@@ -102,7 +102,7 @@ def find(
         :return: A collection of models
         :rtype: List
         """
-        stmt = select(self._model)  # type: ignore
+        stmt = select(self._model)
         if search_params:
             stmt = self._filter_select(stmt, search_params)