Drop support for delete by primary key

Author: febus982

sqlalchemy_bind_manager/_repository/async_.py

@@ -93,17 +93,9 @@ async def get_many(self, identifiers: Iterable[PRIMARY_KEY]) -> List[MODEL]:
         async with self._get_session(commit=False) as session:
             return [x for x in (await session.execute(stmt)).scalars()]
 
-    async def delete(
-        self,
-        entity: Union[MODEL, PRIMARY_KEY],
-    ) -> None:
-        # TODO: delete without loading the model
-        if isinstance(entity, self._model):
-            obj = entity
-        else:
-            obj = await self.get(entity)  # type: ignore
+    async def delete(self, instance: MODEL) -> None:
         async with self._get_session() as session:
-            await session.delete(obj)
+            await session.delete(instance)
 
     async def find(
         self,

sqlalchemy_bind_manager/_repository/sync.py

@@ -82,14 +82,9 @@ def get_many(self, identifiers: Iterable[PRIMARY_KEY]) -> List[MODEL]:
         with self._get_session(commit=False) as session:
             return [x for x in session.execute(stmt).scalars()]
 
-    def delete(self, entity: Union[MODEL, PRIMARY_KEY]) -> None:
-        # TODO: delete without loading the model
-        if isinstance(entity, self._model):
-            obj = entity
-        else:
-            obj = self.get(entity)  # type: ignore
+    def delete(self, instance: MODEL) -> None:
         with self._get_session() as session:
-            session.delete(obj)
+            session.delete(instance)
 
     def find(
         self,

sqlalchemy_bind_manager/protocols.py

@@ -59,11 +59,10 @@ async def get_many(self, identifiers: Iterable[PRIMARY_KEY]) -> List[MODEL]:
         """
         ...
 
-    async def delete(self, entity: Union[MODEL, PRIMARY_KEY]) -> None:
+    async def delete(self, instance: MODEL) -> None:
         """Deletes a model.
 
-        :param entity: The model instance or the primary key
-        :type entity: Union[MODEL, PRIMARY_KEY]
+        :param instance: The model instance or the primary key
         """
         ...
 
@@ -197,7 +196,6 @@ def get(self, identifier: PRIMARY_KEY) -> MODEL:
         :return: A model instance
         :raises ModelNotFound: No model has been found using the primary key
         """
-        # TODO: implement get_many()
         ...
 
     def get_many(self, identifiers: Iterable[PRIMARY_KEY]) -> List[MODEL]:
@@ -210,11 +208,10 @@ def get_many(self, identifiers: Iterable[PRIMARY_KEY]) -> List[MODEL]:
         """
         ...
 
-    def delete(self, entity: Union[MODEL, PRIMARY_KEY]) -> None:
+    def delete(self, instance: MODEL) -> None:
         """Deletes a model.
 
-        :param entity: The model instance or the primary key
-        :type entity: Union[MODEL, PRIMARY_KEY]
+        :param instance: The model instance or the primary key
         """
         ...
 

tests/repository/async_/test_delete.py

@@ -1,26 +1,5 @@
 import pytest
-
-
-async def test_can_delete_by_pk(repository_class, model_class, sa_manager):
-    model = model_class(
-        model_id=1,
-        name="Someone",
-    )
-    model2 = model_class(
-        model_id=2,
-        name="SomeoneElse",
-    )
-    repo = repository_class(sa_manager.get_bind())
-    await repo.save_many({model, model2})
-
-    results = [x for x in await repo.find()]
-    assert len(results) == 2
-
-    await repo.delete(1)
-    results = [x for x in await repo.find()]
-    assert len(results) == 1
-    assert results[0].model_id == 2
-    assert results[0].name == "SomeoneElse"
+from sqlalchemy import select
 
 
 async def test_can_delete_by_instance(repository_class, model_class, sa_manager):
@@ -55,3 +34,26 @@ async def test_delete_inexistent_raises_exception(
 
     with pytest.raises(Exception):
         await repo.delete(4)
+
+
+async def test_relationships_are_respected(
+    related_repository_class, related_model_classes, sa_manager
+):
+    parent = related_model_classes[0](
+        name="A Parent",
+    )
+    child = related_model_classes[1](name="A Child")
+    child2 = related_model_classes[1](name="Another Child")
+    parent.children.append(child)
+    parent.children.append(child2)
+    repo = related_repository_class(sa_manager.get_bind())
+    await repo.save(parent)
+
+    retrieved_parent = await repo.get(parent.parent_model_id)
+    assert len(retrieved_parent.children) == 2
+
+    await repo.delete(retrieved_parent)
+
+    async with repo._get_session() as session:
+        result = [x for x in (await session.execute(select(related_model_classes[1]))).scalars()]
+        assert len(result) == 0

tests/repository/sync/test_delete.py

@@ -1,26 +1,6 @@
 import pytest
 
-
-def test_can_delete_by_pk(repository_class, model_class, sa_manager):
-    model = model_class(
-        model_id=1,
-        name="Someone",
-    )
-    model2 = model_class(
-        model_id=2,
-        name="SomeoneElse",
-    )
-    repo = repository_class(sa_manager.get_bind())
-    repo.save_many({model, model2})
-
-    results = [x for x in repo.find()]
-    assert len(results) == 2
-
-    repo.delete(1)
-    results = [x for x in repo.find()]
-    assert len(results) == 1
-    assert results[0].model_id == 2
-    assert results[0].name == "SomeoneElse"
+from sqlalchemy import select
 
 
 def test_can_delete_by_instance(repository_class, model_class, sa_manager):
@@ -53,3 +33,26 @@ def test_delete_inexistent_raises_exception(repository_class, model_class, sa_ma
 
     with pytest.raises(Exception):
         repo.delete(4)
+
+
+def test_relationships_are_respected(
+    related_repository_class, related_model_classes, sa_manager
+):
+    parent = related_model_classes[0](
+        name="A Parent",
+    )
+    child = related_model_classes[1](name="A Child")
+    child2 = related_model_classes[1](name="Another Child")
+    parent.children.append(child)
+    parent.children.append(child2)
+    repo = related_repository_class(sa_manager.get_bind())
+    repo.save(parent)
+
+    retrieved_parent = repo.get(parent.parent_model_id)
+    assert len(retrieved_parent.children) == 2
+
+    repo.delete(retrieved_parent)
+
+    with repo._get_session() as session:
+        result = [x for x in session.execute(select(related_model_classes[1])).scalars()]
+        assert len(result) == 0