Remove pre1.6 support from string generation

ECJ no longer supports pre 1.8 and JDT UI simply converts project
settings to 1.8 if lower thus all this code is non reachable.

Author: akurtakov

org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/codemanipulation/tostringgeneration/AbstractToStringGenerator.java

@@ -486,10 +486,7 @@ protected void checkNeedForHelperMethods() {
 			}
 			if (fContext.isCustomArray() && memberType.isArray()) {
 				ITypeBinding componentType= memberType.getComponentType();
-				if (componentType.isPrimitive() && (!fContext.is60orHigher() && fContext.isLimitItems())) {
-					if (!typesThatNeedArrayToStringMethod.contains(componentType))
-						typesThatNeedArrayToStringMethod.add(componentType);
-				} else if (!componentType.isPrimitive())
+				if (!componentType.isPrimitive())
 					isNonPrimitive= true;
 			}
 		}
@@ -716,28 +713,15 @@ protected Expression createMemberAccessExpression(Object member, boolean ignoreA
 								MethodInvocation asListInvocation= createMethodInvocation(addImport("java.util.Arrays"), "asList", createMemberAccessExpression(member, true, true)); //$NON-NLS-1$ //$NON-NLS-2$
 								accessExpression= createSubListInvocation(asListInvocation, lengthAccess);
 							} else {
-								if (fContext.is60orHigher()) {
-									// Arrays.toString( Arrays.copyOf ( member, Math.min (maxLen, member.length) )
-									Name arraysImport= addImport("java.util.Arrays"); //$NON-NLS-1$
-									MethodInvocation minInvocation= createMethodInvocation(addImport("java.lang.Math"), "min", lengthAccess); //$NON-NLS-1$ //$NON-NLS-2$
-									minInvocation.arguments().add(fAst.newSimpleName(fMaxLenVariableName));
-									needMaxLenVariable= true;
-									MethodInvocation copyOfInvocation= createMethodInvocation(arraysImport, "copyOf", createMemberAccessExpression(member, true, true)); //$NON-NLS-1$
-									copyOfInvocation.arguments().add(minInvocation);
-									Name arraysImportCopy= (Name)ASTNode.copySubtree(fAst, arraysImport);
-									accessExpression= createMethodInvocation(arraysImportCopy, METHODNAME_TO_STRING, copyOfInvocation);
-								} else {
-									// arrayToString(member, member.length, maxLen)
-									MethodInvocation arrayToStringInvocation= fAst.newMethodInvocation();
-									if (fContext.isKeywordThis())
-										arrayToStringInvocation.setExpression(fAst.newThisExpression());
-									arrayToStringInvocation.setName(fAst.newSimpleName(HELPER_ARRAYTOSTRING_METHOD_NAME));
-									arrayToStringInvocation.arguments().add(createMemberAccessExpression(member, true, true));
-									arrayToStringInvocation.arguments().add(lengthAccess);
-									arrayToStringInvocation.arguments().add(fAst.newSimpleName(fMaxLenVariableName));
-									needMaxLenVariable= true;
-									accessExpression= arrayToStringInvocation;
-								}
+								// Arrays.toString( Arrays.copyOf ( member, Math.min (maxLen, member.length) )
+								Name arraysImport= addImport("java.util.Arrays"); //$NON-NLS-1$
+								MethodInvocation minInvocation= createMethodInvocation(addImport("java.lang.Math"), "min", lengthAccess); //$NON-NLS-1$ //$NON-NLS-2$
+								minInvocation.arguments().add(fAst.newSimpleName(fMaxLenVariableName));
+								needMaxLenVariable= true;
+								MethodInvocation copyOfInvocation= createMethodInvocation(arraysImport, "copyOf", createMemberAccessExpression(member, true, true)); //$NON-NLS-1$
+								copyOfInvocation.arguments().add(minInvocation);
+								Name arraysImportCopy= (Name)ASTNode.copySubtree(fAst, arraysImport);
+								accessExpression= createMethodInvocation(arraysImportCopy, METHODNAME_TO_STRING, copyOfInvocation);
 							}
 						}
 					}

org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/codemanipulation/tostringgeneration/ToStringGenerationContext.java

@@ -81,10 +81,6 @@ public ITypeBinding getTypeBinding() {
 		return fType;
 	}
 
-	public boolean is60orHigher() {
-		return fSettings.is60orHigher;
-	}
-
 	public boolean isCreateComments() {
 		return fSettings.createComments;
 	}

org.eclipse.jdt.core.manipulation/core extension/org/eclipse/jdt/internal/corext/codemanipulation/tostringgeneration/ToStringGenerationSettingsCore.java

@@ -99,9 +99,6 @@ public static class CustomBuilderSettings {
 	/** should blocks be forced in if/for/while statements? */
 	public boolean useBlocks;
 
-	/** can generated code use jdk 1.6 API? **/
-	public boolean is60orHigher;
-
 	/** settings specific for custom builder code style **/
 	public CustomBuilderSettings customBuilderSettings;