Merge tag '1.3.2'

dahlia · dahlia · commit ac4f17712bb7 · 2024-12-18T18:14:21.000+09:00
Fedify 1.3.2
diff --git a/CHANGES.md b/CHANGES.md
@@ -20,6 +20,15 @@ To be released.
 [#195]: https://github.com/dahlia/fedify/issues/195
 
 
+Version 1.3.2
+-------------
+
+Released on December 18, 2024.
+
+ -  Fixed the default document loader to handle the `Link` header with
+    incorrect syntax.  [[#196]]
+
+
 Version 1.3.1
 -------------
 
@@ -146,6 +155,15 @@ Released on November 30, 2024.
 [#193]: https://github.com/dahlia/fedify/issues/193
 
 
+Version 1.2.10
+--------------
+
+Released on December 18, 2024.
+
+ -  Fixed the default document loader to handle the `Link` header with
+    incorrect syntax.  [[#196]]
+
+
 Version 1.2.9
 -------------
 
@@ -361,6 +379,15 @@ Released on October 31, 2024.
 [#118]: https://github.com/dahlia/fedify/issues/118
 
 
+Version 1.1.10
+--------------
+
+Released on December 18, 2024.
+
+ -  Fixed the default document loader to handle the `Link` header with
+    incorrect syntax.  [[#196]]
+
+
 Version 1.1.9
 -------------
 
@@ -617,6 +644,17 @@ Released on October 20, 2024.
 [#150]: https://github.com/dahlia/fedify/issues/150
 
 
+Version 1.0.13
+--------------
+
+Released on December 18, 2024.
+
+ -  Fixed the default document loader to handle the `Link` header with
+    incorrect syntax.  [[#196]]
+
+[#196]: https://github.com/dahlia/fedify/issues/196
+
+
 Version 1.0.12
 --------------
 
diff --git a/src/runtime/docloader.test.ts b/src/runtime/docloader.test.ts
@@ -101,6 +101,24 @@ test("getDocumentLoader()", async (t) => {
       },
     ));
 
+  mf.mock("GET@/obj-w-wrong-link", (_req) =>
+    new Response(
+      JSON.stringify({
+        "@context": "https://www.w3.org/ns/activitystreams",
+        id: "https://example.com/obj-w-wrong-link",
+        name: "Fetched object",
+        type: "Object",
+      }),
+      {
+        status: 200,
+        headers: {
+          "Content-Type": "text/html; charset=utf-8",
+          Link: '<https://example.com/object>; rel="alternate"; ' +
+            'type="application/ld+json; profile="https://www.w3.org/ns/activitystreams""',
+        },
+      },
+    ));
+
   await t.step("Link header", async () => {
     assertEquals(await fetchDocumentLoader("https://example.com/link-ctx"), {
       contextUrl: "https://www.w3.org/ns/activitystreams",
@@ -150,6 +168,22 @@ test("getDocumentLoader()", async (t) => {
     );
   });
 
+  await t.step("wrong Link header syntax", async () => {
+    assertEquals(
+      await fetchDocumentLoader("https://example.com/obj-w-wrong-link"),
+      {
+        contextUrl: null,
+        documentUrl: "https://example.com/obj-w-wrong-link",
+        document: {
+          "@context": "https://www.w3.org/ns/activitystreams",
+          id: "https://example.com/obj-w-wrong-link",
+          name: "Fetched object",
+          type: "Object",
+        },
+      },
+    );
+  });
+
   mf.mock("GET@/html-link", (_req) =>
     new Response(
       `<html>
diff --git a/src/runtime/docloader.ts b/src/runtime/docloader.ts
@@ -133,7 +133,16 @@ async function getRemoteDocument(
   const linkHeader = response.headers.get("Link");
   let contextUrl: string | null = null;
   if (linkHeader != null) {
-    const link = new HTTPHeaderLink(linkHeader);
+    let link: HTTPHeaderLink;
+    try {
+      link = new HTTPHeaderLink(linkHeader);
+    } catch (e) {
+      if (e instanceof SyntaxError) {
+        link = new HTTPHeaderLink();
+      } else {
+        throw e;
+      }
+    }
     if (jsonLd) {
       const entries = link.getByRel("http://www.w3.org/ns/json-ld#context");
       for (const [uri, params] of entries) {
