Make S3_REGION required if DRIVE_DISK=s3

Fix #95

Author: dahlia

CHANGES.md

@@ -40,6 +40,10 @@ To be released.
  -  On profile page, the favicon is now switched between light and dark mode
     according to the user's preference.  [[#101]]
 
+ -  The `S3_REGION` environment variable became required if `DRIVE_DISK` is set
+    to `s3`.  [[#95]]
+
+[#95]: https://github.com/fedify-dev/hollo/issues/95
 [#99]: https://github.com/fedify-dev/hollo/issues/99
 [#100]: https://github.com/fedify-dev/hollo/pull/100
 [#101]: https://github.com/fedify-dev/hollo/issues/101

docs/src/content/docs/install/env.mdx

@@ -193,10 +193,10 @@ The public URL base of the asset storage, e.g.,
   - Must be publicly accessible for federation to work correctly.
 </Aside>
 
-#### `S3_REGION` <Badge text="Optional" />
+#### `S3_REGION` <Badge text="Required with S3 driver" variant="caution" />
 
 The region of the S3-compatible object storage, e.g., `us-east-1`.  On some
-non-S3 services, this can be omitted.  `auto` by default.
+non-S3 services, this can be omitted.
 
 #### `S3_BUCKET` <Badge text="Required with S3 driver" variant="caution" />
 

docs/src/content/docs/ja/install/env.mdx

@@ -193,14 +193,12 @@ Holloでアバター、カスタム絵文字、
   - 公開的にアクセス可能でなければ、連合が正しく動作しません。
 </Aside>
 
-#### `S3_REGION` <Badge text="オプション" />
+#### `S3_REGION` <Badge text="S3ドライバで必須" variant="caution" />
 
 S3互換オブジェクトストレージのリージョン。例：`us-east-1`
 
 一部の非AWS S3互換サービスでは、この値が必要ないかもしれません。
 
-デフォルトは`auto`です。
-
 #### `S3_BUCKET` <Badge text="S3ドライバで必須" variant="caution" />
 
 S3互換オブジェクトストレージのバケット名。例：`hollo`

docs/src/content/docs/ko/install/env.mdx

@@ -191,13 +191,11 @@ Hollo에서 프로필 사진, 커스텀 에모지, 기타 미디어와 같은 
   - 공개적으로 접근 가능해야 연합이 올바르게 작동합니다.
 </Aside>
 
-#### `S3_REGION` <Badge text="선택" />
+#### `S3_REGION` <Badge text="S3 드라이버에서 필수" variant="caution" />
 
 S3 호환 오브젝트 스토리지의 지역. 예: `us-east-1`.
 몇몇 AWS가 아닌 S3 호환 서비스에서는 이 값이 필요 없을 수 있습니다.
 
-기본값은 `auto`입니다.
-
 #### `S3_BUCKET` <Badge text="S3 드라이버에서 필수" variant="caution" />
 
 S3 호환 오브젝트 스토리지의 버킷 이름. 예: `hollo`.

docs/src/content/docs/zh-cn/install/env.mdx

@@ -176,9 +176,9 @@ Sentry项目的DSN，用于发送错误报告和跟踪信息。
   - 必须可公开访问，联盟才能正常工作。
 </Aside>
 
-#### `S3_REGION` <Badge text="可选" />
+#### `S3_REGION` <Badge text="S3 驱动程序必填" variant="caution" />
 
-S3兼容对象存储的区域，例如：`us-east-1`。在某些非S3服务中，可以省略此项。默认为`auto`。
+S3兼容对象存储的区域，例如：`us-east-1`。在某些非S3服务中，可以省略此项。
 
 #### `S3_BUCKET` <Badge text="S3 驱动程序必填" variant="caution" />
 

src/storage.ts

@@ -91,15 +91,17 @@ switch (DRIVE_DISK) {
     break;
   case "s3":
     if (bucket == null) throw new Error("S3_BUCKET is required");
+    if (region == null) throw new Error("S3_REGION is required");
     if (accessKeyId == null) throw new Error("AWS_ACCESS_KEY_ID is required");
-    if (secretAccessKey == null)
+    if (secretAccessKey == null) {
       throw new Error("AWS_SECRET_ACCESS_KEY is required");
+    }
 
     driver = new S3Driver({
       credentials: fromEnv(),
-      region: region == null || region === "" ? "auto" : region,
+      region,
       endpoint: endpointUrl,
-      bucket: bucket,
+      bucket,
       // biome-ignore lint/complexity/useLiteralKeys: tsc complains about this (TS4111)
       forcePathStyle: process.env["S3_FORCE_PATH_STYLE"] === "true",
       visibility: "public",