Store API key for LLM inference in a file

Signed-off-by: Jiri Podivin <jpodivin@redhat.com>

Author: jpodivin

README.md

@@ -51,13 +51,14 @@ Evaluation of Log Detective performance can be performed automatically using
 the `validation.py`script. Dependencies for the tool are defined in the
 `requirements.txt` file and should be installed in a virtual environment.
 
-Before running the script, the API key for the LLM judge must be set
-in an environment variable `OPENAI_API_KEY`.
+Keys for OpenAI compatible LLM inference provider and Log Detective itself,
+must be stored in files. These will be used at runtime.
+This prevents logging of secrets in history.
 
 Example:
 
 ```
-./validation.py <DATA_PATH> <LOG_DETECTIVE_URL> <LLM_URL> <LLM_NAME>
+./validation.py <PATH_TO_OPEN_AI_API_KEY> <DATA_PATH> <LOG_DETECTIVE_URL> <LLM_URL> <LLM_NAME>
 ```
 Script sends each of the the stored log files for evaluation by Log Detective,
 then submits both results of final analysis from Log Detective and actual issue

validation.py

@@ -10,10 +10,6 @@
 import argparse
 from pydantic import BaseModel, Field, ValidationError
 
-# --- Configuration ---
-# Set your OpenAI API key as an environment variable named OPENAI_API_KEY
-# You can get a key from https://beta.openai.com/account/api-keys
-API_KEY = os.getenv("OPENAI_API_KEY")
 LOG_REPO_BASE_URL = (
     "https://raw.githubusercontent.com/fedora-copr/logdetective-sample/main/data/"
 )
@@ -222,6 +218,11 @@ def main():
         description="Evaluate AI system performance by comparing expected and actual responses.",
         formatter_class=argparse.ArgumentDefaultsHelpFormatter
     )
+    parser.add_argument(
+        "open_ai_api_key",
+        help="Path to file with API key to OpenAI compatible inference provider",
+        type=str,
+    )
     parser.add_argument(
         "data_directory", help="Path to the directory containing the sample data."
     )
@@ -245,9 +246,7 @@ def main():
     )
     args = parser.parse_args()
 
-    if not API_KEY:
-        print("Error: OPENAI_API_KEY environment variable not set.", file=sys.stderr)
-        sys.exit(1)
+    open_ai_api_key = get_api_key_from_file(args.open_ai_api_key)
 
     if not os.path.isdir(args.data_directory):
         print(f"Error: Directory not found at '{args.data_directory}'", file=sys.stderr)
@@ -262,7 +261,7 @@ def main():
         server_address=args.logdetective_url,
         llm_url=args.llm_url,
         llm_model=args.llm_model,
-        llm_token=API_KEY,
+        llm_token=open_ai_api_key,
         log_detective_api_timeout=args.log_detective_api_timeout,
         log_detective_api_key=log_detective_api_key
     )