MNT: Make unused imports explicit

... instead of using a full file ignore. This allows catching a few more
unused imports.

Author: QuLogic

.flake8

@@ -31,26 +31,20 @@ exclude =
     .eggs
 
 per-file-ignores =
-    lib/matplotlib/__init__.py: E402, F401
     lib/matplotlib/_animation_data.py: E501
-    lib/matplotlib/_api/__init__.py: F401
     lib/matplotlib/_cm.py: E122, E202, E203, E302
     lib/matplotlib/_mathtext.py: E221, E251
     lib/matplotlib/_mathtext_data.py: E122, E203, E261
-    lib/matplotlib/axes/__init__.py: F401, F403
     lib/matplotlib/backends/backend_template.py: F401
     lib/matplotlib/font_manager.py: E501
-    lib/matplotlib/image.py: F401, F403
     lib/matplotlib/mathtext.py: E221
     lib/matplotlib/pylab.py: F401, F403
-    lib/matplotlib/pyplot.py: F401, F811
+    lib/matplotlib/pyplot.py: F811
     lib/matplotlib/tests/test_mathtext.py: E501
     lib/matplotlib/transforms.py: E201, E202, E203
     lib/matplotlib/tri/_triinterpolate.py: E201, E221
     lib/mpl_toolkits/axes_grid1/axes_size.py: E272
-    lib/mpl_toolkits/axisartist/__init__.py: F401
     lib/mpl_toolkits/axisartist/angle_helper.py: E221
-    lib/pylab.py: F401, F403
 
     doc/conf.py: E402
     galleries/users_explain/artists/paths.py: E402

lib/matplotlib/__init__.py

@@ -151,17 +151,16 @@
 import subprocess
 import sys
 import tempfile
-import warnings
 
-import numpy
 from packaging.version import parse as parse_version
 
 # cbook must import matplotlib only within function
 # definitions, so it is safe to import from it here.
 from . import _api, _version, cbook, _docstring, rcsetup
 from matplotlib.cbook import sanitize_sequence
 from matplotlib._api import MatplotlibDeprecationWarning
-from matplotlib.rcsetup import validate_backend, cycler
+from matplotlib.rcsetup import cycler  # noqa: F401
+from matplotlib.rcsetup import validate_backend
 
 
 _log = logging.getLogger(__name__)
@@ -246,7 +245,7 @@ def _check_versions():
 
     # Quickfix to ensure Microsoft Visual C++ redistributable
     # DLLs are loaded before importing kiwisolver
-    from . import ft2font
+    from . import ft2font  # noqa: F401
 
     for modname, minver in [
             ("cycler", "0.10"),
@@ -1511,5 +1510,5 @@ def inner(ax, *args, data=None, **kwargs):
 
 # workaround: we must defer colormaps import to after loading rcParams, because
 # colormap creation depends on rcParams
-from matplotlib.cm import _colormaps as colormaps
-from matplotlib.colors import _color_sequences as color_sequences
+from matplotlib.cm import _colormaps as colormaps  # noqa: E402
+from matplotlib.colors import _color_sequences as color_sequences  # noqa: E402

lib/matplotlib/_api/__init__.py

@@ -16,7 +16,7 @@
 import sys
 import warnings
 
-from .deprecation import (
+from .deprecation import (  # noqa: F401
     deprecated, warn_deprecated,
     rename_parameter, delete_parameter, make_keyword_only,
     deprecate_method_override, deprecate_privatize_attribute,

lib/matplotlib/axes/__init__.py

@@ -1,8 +1,8 @@
 from . import _base
-from ._axes import *
+from ._axes import Axes  # noqa: F401
 
 # Backcompat.
-from ._axes import Axes as Subplot
+Subplot = Axes
 
 
 class _SubplotBaseMeta(type):

lib/matplotlib/image.py

@@ -19,7 +19,7 @@
 from matplotlib import _image
 # For user convenience, the names from _image are also imported into
 # the image namespace
-from matplotlib._image import *
+from matplotlib._image import *  # noqa: F401, F403
 import matplotlib.artist as martist
 from matplotlib.backend_bases import FigureCanvasBase
 import matplotlib.colors as mcolors

lib/matplotlib/pyplot.py

@@ -45,20 +45,20 @@
 import importlib
 import inspect
 import logging
-import re
 import sys
 import threading
 import time
-from typing import cast, overload
+from typing import TYPE_CHECKING, cast, overload
 
-from cycler import cycler
+from cycler import cycler  # noqa: F401
 import matplotlib
 import matplotlib.colorbar
 import matplotlib.image
 from matplotlib import _api
-from matplotlib import (  # Re-exported for typing.
+from matplotlib import (  # noqa: F401 Re-exported for typing.
     cm as cm, get_backend as get_backend, rcParams as rcParams, style as style)
-from matplotlib import _pylab_helpers, interactive
+from matplotlib import _pylab_helpers
+from matplotlib import interactive  # noqa: F401
 from matplotlib import cbook
 from matplotlib import _docstring
 from matplotlib.backend_bases import (
@@ -67,19 +67,18 @@
 from matplotlib.gridspec import GridSpec, SubplotSpec
 from matplotlib import rcsetup, rcParamsDefault, rcParamsOrig
 from matplotlib.artist import Artist
-from matplotlib.axes import Axes, Subplot  # type: ignore
+from matplotlib.axes import Axes
+from matplotlib.axes import Subplot  # noqa: F401
 from matplotlib.projections import PolarAxes  # type: ignore
 from matplotlib import mlab  # for detrend_none, window_hanning
-from matplotlib.scale import get_scale_names
+from matplotlib.scale import get_scale_names  # noqa: F401
 
 from matplotlib.cm import _colormaps
-from matplotlib.cm import register_cmap  # type: ignore
+from matplotlib.cm import register_cmap  # type: ignore # noqa: F401
 from matplotlib.colors import _color_sequences
 
 import numpy as np
 
-from typing import TYPE_CHECKING, cast
-
 if TYPE_CHECKING:
     from collections.abc import Callable, Hashable, Iterable, Sequence
     import datetime
@@ -131,10 +130,11 @@
 from matplotlib.colors import Normalize
 from matplotlib.lines import Line2D, AxLine
 from matplotlib.text import Text, Annotation
-from matplotlib.patches import Polygon, Rectangle, Circle, Arrow
-from matplotlib.widgets import Button, Slider, Widget
+from matplotlib.patches import Arrow, Circle, Rectangle  # noqa: F401
+from matplotlib.patches import Polygon
+from matplotlib.widgets import Button, Slider, Widget  # noqa: F401
 
-from .ticker import (
+from .ticker import (  # noqa: F401
     TickHelper, Formatter, FixedFormatter, NullFormatter, FuncFormatter,
     FormatStrFormatter, ScalarFormatter, LogFormatter, LogFormatterExponent,
     LogFormatterMathtext, Locator, IndexLocator, FixedLocator, NullLocator,

lib/mpl_toolkits/axisartist/__init__.py

@@ -1,9 +1,10 @@
-from .axislines import (
-    Axes, AxesZero, AxisArtistHelper, AxisArtistHelperRectlinear,
+from .axislines import Axes
+from .axislines import (  # noqa: F401
+    AxesZero, AxisArtistHelper, AxisArtistHelperRectlinear,
     GridHelperBase, GridHelperRectlinear, Subplot, SubplotZero)
-from .axis_artist import AxisArtist, GridlinesCollection
-from .grid_helper_curvelinear import GridHelperCurveLinear
-from .floating_axes import FloatingAxes, FloatingSubplot
+from .axis_artist import AxisArtist, GridlinesCollection  # noqa: F401
+from .grid_helper_curvelinear import GridHelperCurveLinear  # noqa: F401
+from .floating_axes import FloatingAxes, FloatingSubplot  # noqa: F401
 from mpl_toolkits.axes_grid1.parasite_axes import (
     host_axes_class_factory, parasite_axes_class_factory)
 

lib/pylab.py

@@ -1,3 +1,3 @@
-from matplotlib.pylab import *
+from matplotlib.pylab import *  # noqa: F401, F403
 import matplotlib.pylab
 __doc__ = matplotlib.pylab.__doc__