Review comments

Author: ianthomas23

lib/matplotlib/backend_bases.py

@@ -106,7 +106,7 @@ def _safe_pyplot_import():
             raise  # No, something else went wrong, likely with the install...
 
         from matplotlib.backends.registry import backend_registry
-        backend = backend_registry.framework_to_backend(current_framework)
+        backend = backend_registry.backend_for_gui_framework(current_framework)
         if backend is None:
             raise KeyError(backend)
 

lib/matplotlib/backends/registry.py

@@ -31,7 +31,7 @@ class BackendRegistry:
     _BUILTIN_NOT_INTERACTIVE = [
         "agg", "cairo", "pdf", "pgf", "ps", "svg", "template",
     ]
-    _FRAMEWORK_TO_BACKEND_MAPPING = {
+    _GUI_FRAMEWORK_TO_BACKEND_MAPPING = {
         "qt": "qtagg",
         "gtk3": "gtk3agg",
         "gtk4": "gtk4agg",
@@ -41,8 +41,8 @@ class BackendRegistry:
         "headless": "agg",
     }
 
-    def framework_to_backend(self, interactive_framework):
-        return self._FRAMEWORK_TO_BACKEND_MAPPING.get(interactive_framework)
+    def backend_for_gui_framework(self, framework):
+        return self._GUI_FRAMEWORK_TO_BACKEND_MAPPING.get(framework)
 
     def list_builtin(self, filter_=None):
         if filter_ == BackendFilter.INTERACTIVE:

lib/matplotlib/backends/registry.pyi

@@ -9,7 +9,7 @@ class BackendFilter(Enum):
 
 class BackendRegistry:
     def __init__(self) -> None: ...
-    def framework_to_backend(self, interactive_framework: str) -> str | None: ...
+    def backend_for_gui_framework(self, interactive_framework: str) -> str | None: ...
     def list_builtin(self, filter_: BackendFilter | None) -> list[str]: ...
 
 

lib/matplotlib/pyplot.py

@@ -304,7 +304,8 @@ def switch_backend(newbackend: str) -> None:
         current_framework = cbook._get_running_interactive_framework()
 
         if (current_framework and
-                (backend := backend_registry.framework_to_backend(current_framework))):
+                (backend := backend_registry.backend_for_gui_framework(
+                current_framework))):
             candidates = [backend]
         else:
             candidates = []
@@ -2505,7 +2506,7 @@ def polar(*args, **kwargs) -> list[Line2D]:
 # is compatible with the current running interactive framework.
 if (rcParams["backend_fallback"]
         and rcParams._get_backend_or_none() in (  # type: ignore
-            set(backend_registry.list_builtin(BackendFilter.INTERACTIVE_NON_WEB)))
+            backend_registry.list_builtin(BackendFilter.INTERACTIVE_NON_WEB))
         and cbook._get_running_interactive_framework()):  # type: ignore
     rcParams._set("backend", rcsetup._auto_backend_sentinel)  # type: ignore
 

lib/matplotlib/tests/test_backend_registry.py

@@ -23,8 +23,8 @@ def has_duplicates(seq: Sequence[Any]) -> bool:
         ('does not exist', None),
     ]
 )
-def test_framework_to_backend(framework, expected):
-    assert backend_registry.framework_to_backend(framework) == expected
+def test_backend_for_gui_framework(framework, expected):
+    assert backend_registry.backend_for_gui_framework(framework) == expected
 
 
 def test_list_builtin():