Don't use LD_LIBRARY_PATH when running tests

nikic · nikic · commit e72d2332cad2 · 2025-01-24T10:01:20.000Z
This is no longer needed now that we use rpath during the build.

Using LD_LIBRARY_PATH causes us to load the wrong libclang.so
if system clang is invoked during the tests, which happens in the
mlir tests.
diff --git a/llvm.spec b/llvm.spec
@@ -1771,9 +1771,6 @@ cd llvm
 # Call this function before setting up a next component to test.
 function reset_test_opts()
 {
-    # Some libraries will not be found if we don't set this
-    export LD_LIBRARY_PATH="%{buildroot}/%{install_libdir}:%{buildroot}/%{_libdir}";
-
     # See https://llvm.org/docs/CommandGuide/lit.html#general-options
     export LIT_OPTS="-vv --time-tests"
 

Original file line number	Diff line number	Diff line change
`@@ -1771,9 +1771,6 @@ cd llvm`
`1771`	`1771`	`# Call this function before setting up a next component to test.`
`1772`	`1772`	`function reset_test_opts()`
`1773`	`1773`	`{`
`1774`		`- # Some libraries will not be found if we don't set this`
`1775`		`- export LD_LIBRARY_PATH="%{buildroot}/%{install_libdir}:%{buildroot}/%{_libdir}";`
`1776`		`-`
`1777`	`1774`	`# See https://llvm.org/docs/CommandGuide/lit.html#general-options`
`1778`	`1775`	`export LIT_OPTS="-vv --time-tests"`
`1779`	`1776`