Merge pull request #247 from fedspendingtransparency/fix/share-icon-dep

Fix Share Icon dependency

Author: anjenkin

README.md

@@ -74,7 +74,11 @@ To test components locally in the context it will be used either use `npm link`:
 3. Run npm link path/to/your/<consumer-context>/node_modules/react (example npm link ../<consumer-context>/node_modules/react; to integrate with usaspending.gov use `npm link ../usaspending-website/node_modules/react`)
 4. Navigate to the consumer context directory (i.e. for usaspending.gov the consumer context directory is "usaspending-website")
 5. Run `npm link data-transparency-ui`
-6. NOTE: After work is finished with the linked consumer context, it will be necessary to then unlink this library by doing the following:
+6. If you notice the link is not working as expected you may need to clear your consumer context directory cache
+    1. Run `npm cache clean --force` in your consumer context directory
+    2. Repeat link steps above
+
+7. NOTE: After work is finished with the linked consumer context, it will be necessary to then unlink this library by doing the following:
    1. Navigate to the consumer context directory again.
    2. Run `npm unlink --no-save data-transparency-ui`
    3. Navigate to the `data-transparency-ui/` root.

components/ShareIcon.jsx

@@ -83,7 +83,7 @@ const ShareIcon = ({
             hideConfirmationText();
         }
         return hideConfirmationText.cancel;
-    }, []);
+    }, [showConfirmationText]);
 
     return (
         <div className={`${classNames ? `usda-share-icon${disabledClass} ${classNames}` : `usda-share-icon${disabledClass}`}`}>