Add UT for method classify

There was not UT to check that #classify returns the correct value.

Add UT #canGetClassDistributionMaxValueIndex to check that #classify returns index of max value.

Author: shengwangsw

openml-generic-python/src/test/java/com/feedzai/openml/python/PythonModelProviderTest.java

@@ -19,6 +19,7 @@
 import com.feedzai.openml.data.Instance;
 import com.feedzai.openml.data.schema.DatasetSchema;
 import com.feedzai.openml.mocks.MockDataset;
+import com.feedzai.openml.model.ClassificationMLModel;
 import com.feedzai.openml.provider.exception.ModelLoadingException;
 import com.feedzai.openml.util.algorithm.GenericAlgorithm;
 import com.feedzai.openml.util.algorithm.MLAlgorithmEnum;
@@ -104,6 +105,24 @@ public class PythonModelProviderTest extends AbstractProviderModelLoadTest<Class
     @Rule
     public final ExpectedException exception = ExpectedException.none();
 
+    /**
+     * Verifies that the {@link ClassificationMLModel#classify(Instance)} " returns the index of the greatest value in
+     * the class probability distribution produced by the calling
+     * {@link ClassificationMLModel#getClassDistribution(Instance)} on the model
+     *
+     * @see ClassificationMLModel
+     */
+    @Test
+    public void canGetClassDistributionMaxValueIndex() throws Exception {
+
+        final ClassificationPythonModel model = getSecondModel();
+
+        final Instance instance = getDummyInstance();
+
+        this.canGetClassDistributionMaxValueIndex(model, instance);
+
+    }
+
     /**
      * Tests loading a model that is not compatible with the given schema.
      * Should throw a ModelLoadingException.

openml-scikit/src/test/java/com/feedzai/openml/scikit/ScikitModelProviderTest.java

@@ -19,6 +19,7 @@
 import com.feedzai.openml.data.Instance;
 import com.feedzai.openml.data.schema.DatasetSchema;
 import com.feedzai.openml.mocks.MockDataset;
+import com.feedzai.openml.model.ClassificationMLModel;
 import com.feedzai.openml.provider.exception.ModelLoadingException;
 import com.feedzai.openml.python.ClassificationPythonModel;
 import com.feedzai.openml.util.algorithm.MLAlgorithmEnum;
@@ -95,6 +96,24 @@ public class ScikitModelProviderTest extends AbstractProviderModelLoadTest<Class
     @Rule
     public final ExpectedException exception = ExpectedException.none();
 
+    /**
+     * Verifies that the {@link ClassificationMLModel#classify(Instance)} " returns the index of the greatest value in
+     * the class probability distribution produced by the calling
+     * {@link ClassificationMLModel#getClassDistribution(Instance)} on the model
+     *
+     * @see ClassificationMLModel
+     */
+    @Test
+    public void canGetClassDistributionMaxValueIndex() throws Exception {
+
+        final ClassificationPythonModel model = getFirstModel();
+
+        final Instance instance = getDummyInstance();
+
+        this.canGetClassDistributionMaxValueIndex(model, instance);
+
+    }
+
     /**
      * Tests loading a model that does not support class distribution classification.
      * Should throw a ModelLoadingException.

pom.xml

@@ -79,7 +79,7 @@
         <assertj.version>3.7.0</assertj.version>
         <jackson.version>2.6.7</jackson.version>
         <jackson-databind.version>2.6.7</jackson-databind.version>
-        <openml-api.version>0.4.2</openml-api.version>
+        <openml-api.version>0.4.3</openml-api.version>
         <jep.version>3.7.0</jep.version>
     </properties>