Bump OpenML API Version to 1.0.0 (#29)

* Bump OpenML API Version to 1.0.0

Summary:
Despite the bump, some code had to be changed to accomodate the new breaking changes

* Forbide dataset schemas with no target variable.

* Adrress Codacy report

* Remove unused import

Author: JPDSousa

openml-python-common/src/main/java/com/feedzai/openml/python/ClassificationPythonModel.java

@@ -121,11 +121,12 @@ public ClassificationPythonModel(final JepInstance jepInstance,
                                      final String id,
                                      final String classifyFunctionName,
                                      final String getClassDistributionFunctionName) {
-
+        final int targetIndex = schema.getTargetIndex()
+                .orElseThrow(() -> new IllegalArgumentException("Python classification models do not support datasets without schema."));
         this.jepInstance = jepInstance;
         this.schema = schema;
         this.predictiveFieldIndexes = IntStream.range(0, schema.getFieldSchemas().size())
-                .filter(index -> index != schema.getTargetIndex())
+                .filter(index -> index != targetIndex)
                 .toArray();
 
         this.id = id;

openml-python-common/src/test/java/com/feedzai/openml/python/ClassificationPythonModelTest.java

@@ -0,0 +1,62 @@
+package com.feedzai.openml.python;/*
+ * The copyright of this file belongs to Feedzai. The file cannot be
+ * reproduced in whole or in part, stored in a retrieval system,
+ * transmitted in any form, or by any means electronic, mechanical,
+ * photocopying, or otherwise, without the prior permission of the owner.
+ *
+ * © 2019 Feedzai, Strictly Confidential
+ */
+
+import com.feedzai.openml.data.schema.DatasetSchema;
+import com.feedzai.openml.data.schema.FieldSchema;
+import com.feedzai.openml.data.schema.NumericValueSchema;
+import com.feedzai.openml.python.jep.instance.JepInstance;
+import com.google.common.collect.ImmutableList;
+import org.junit.Before;
+import org.junit.Test;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/**
+ * Tests the behaviour of a {@link ClassificationPythonModel}.
+ *
+ * @author Joao Sousa (joao.sousa@feedzai.com)
+ * @since @@@feedzai.next.release@@@
+ */
+public class ClassificationPythonModelTest {
+
+    /**
+     * A field to use in the tests.
+     */
+    private static final FieldSchema FIELD_SCHEMA =
+            new FieldSchema("field", 0, new NumericValueSchema(false));
+
+
+    /**
+     * The wrapper for the Jep object used in the tests.
+     */
+    private JepInstance jepInstance;
+
+    /**
+     * Initializes an instance of {@link JepInstance}.
+     */
+    @Before
+    public void setUp() {
+        this.jepInstance = new JepInstance();
+        this.jepInstance.start();
+    }
+
+    /**
+     * Tests that by passing a dataset schema with no target variable, will make the model creation fail.
+     */
+    @Test
+    public final void testSchemaWithoutTargetVariable() {
+        final ImmutableList<FieldSchema> fields = ImmutableList.of(FIELD_SCHEMA);
+        final DatasetSchema schema = new DatasetSchema(fields);
+
+        assertThatThrownBy(() -> new ClassificationPythonModel(this.jepInstance, schema, "classificationModel"))
+                .as("A classification model created with a schema with no target variable")
+                .isInstanceOf(IllegalArgumentException.class);
+    }
+
+}

pom.xml

@@ -79,7 +79,7 @@
         <assertj.version>3.7.0</assertj.version>
         <jackson.version>2.6.7</jackson.version>
         <jackson-databind.version>2.6.7</jackson-databind.version>
-        <openml-api.version>0.3.0</openml-api.version>
+        <openml-api.version>1.0.0</openml-api.version>
         <jep.version>3.7.0</jep.version>
     </properties>