Skip to content

Commit 181ef69

Browse files
committed
Stop exposing (potentially) unsafe internals
1 parent 4cdc514 commit 181ef69

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

simpletoast.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
*/
44
(() => {
55
if (window !== window.top) return;
6-
const version = buildVersion(1, 7, 1);
6+
const version = buildVersion(1, 7, 2);
77
if (window.SimpleToast) {
88
if (SimpleToast.version) {
99
if (SimpleToast.version >= version.number) return;
@@ -131,7 +131,8 @@
131131
if (typeof arguments[0] === 'string') {
132132
text = arguments[0];
133133
}
134-
if (!text) return blankToast;
134+
const safeToast = Object.assign({}, blankToast);
135+
if (!text) return safeToast;
135136
const id = count++;
136137
const el = document.createElement('div');
137138
if (className) {
@@ -213,7 +214,8 @@
213214
if (timeout) {
214215
startTimeout();
215216
}
216-
return toast;
217+
Object.keys(safeToast).forEach((key) => safeToast[key] = toast[key]);
218+
return safeToast;
217219
}
218220

219221
Toast.version = version.number;

0 commit comments

Comments
 (0)