Skip to content

Commit 45e5e28

Browse files
authored
feat(bloc_lint): support latest analyzer frontend (#4742)
1 parent 9d7163e commit 45e5e28

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

.github/workflows/main.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,8 +279,6 @@ jobs:
279279
codecov_token: ${{ secrets.CODECOV_TOKEN }}
280280
working_directory: packages/${{ matrix.package }}
281281
min_coverage: 100
282-
# TODO(felangel): remove when bloc_lint v0.4.0 is released.
283-
collect_score: ${{ matrix.package != 'bloc_lint' }}
284282

285283
bloc_tools_compile_checks:
286284
needs: changes
@@ -385,6 +383,7 @@ jobs:
385383
analyze_directories: lib
386384
collect_coverage: false
387385
collect_score: false
386+
flutter_channel: master
388387
working_directory: examples/${{ matrix.example }}
389388

390389
docs_checks:

packages/bloc_lint/lib/src/linter.dart

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
import 'dart:convert';
22
import 'dart:io';
33

4+
// Use the experimental features from the shared frontend.
5+
// ignore: implementation_imports
6+
import 'package:_fe_analyzer_shared/src/parser/experimental_features.dart'
7+
show DefaultExperimentalFeatures;
8+
49
// Use the parser from the shared frontend.
510
// ignore: implementation_imports
611
import 'package:_fe_analyzer_shared/src/parser/parser.dart' show Parser;
@@ -93,7 +98,10 @@ class Linter {
9398
final context = LintContext._(rule: rule, document: document);
9499
final listener = rule.create(context);
95100
if (listener == null) continue;
96-
Parser(listener).parseUnit(tokens);
101+
Parser(
102+
listener,
103+
experimentalFeatures: const DefaultExperimentalFeatures(),
104+
).parseUnit(tokens);
97105
diagnostics.addAll(context.diagnostics);
98106
}
99107
return results;

packages/bloc_lint/lib/src/rules/avoid_public_fields.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ class _Listener extends Listener {
5252
}
5353

5454
@override
55-
void endClassFields(
55+
void endFields(
56+
DeclarationKind kind,
5657
Token? abstractToken,
5758
Token? augmentToken,
5859
Token? externalToken,

packages/bloc_lint/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ environment:
1212
sdk: ">=3.7.0 <4.0.0"
1313

1414
dependencies:
15-
_fe_analyzer_shared: ">=75.0.0 <=91.0.0"
15+
_fe_analyzer_shared: ">=93.0.0 <95.0.0"
1616
checked_yaml: ^2.0.0
1717
collection: ^1.0.0
1818
glob: ^2.0.0

0 commit comments

Comments
 (0)