Merge pull request #877 from msaizar/remove-ann001

pydanny · web-flow · commit d20da119a90a · 2025-12-04T14:34:42.000+08:00
Remove ANN001 from pyproject.toml
diff --git a/examples/airblog/airblog.py b/examples/airblog/airblog.py
@@ -39,14 +39,14 @@ def get_tags() -> dict[str, int]:
     return tags
 
 
-def NavBar(request):
+def NavBar(request: air.Request):
     return air.Nav(
         air.A("Home", href=request.url_for("index")),
         air.A("Tags", href=tags.url()),
     )
 
 
-def BlogPostPreview(article, request):
+def BlogPostPreview(article: dict, request: air.Request):
     return air.Aside(
         air.H3(
             air.A(
diff --git a/examples/airblog/test_airblog.py b/examples/airblog/test_airblog.py
@@ -5,6 +5,7 @@
 import multiprocessing
 import socket
 import time
+from multiprocessing.queues import Queue
 
 import pytest
 import uvicorn
@@ -26,7 +27,7 @@ def get_free_port() -> int:
     return port
 
 
-def run_server(port_queue):
+def run_server(port_queue: Queue[int]) -> None:
     "Runs the AirBlog server on a free port and communicates the port back via a queue."
     # Get an available port number from the operating system
     port = get_free_port()
@@ -81,15 +82,15 @@ def test_index_route_renders():
 
 
 # END-TO-END TEST - Tests full application flow with real browser
-def test_navigate_to_article_via_click(page: Page, live_server):
+def test_navigate_to_article_via_click(page: Page, live_server: int) -> None:
     page.goto(f"http://localhost:{live_server}")
     page.click("text=Hello World")
     expect(page).to_have_url(f"http://localhost:{live_server}/article/hello-world")
     expect(page.locator("h1")).to_contain_text("Hello World")
 
 
 # ACCESSIBILITY TEST - Verifies proper semantic structure
-def test_page_accessibility(page: Page, live_server):
+def test_page_accessibility(page: Page, live_server: int) -> None:
     page.goto(f"http://localhost:{live_server}")
     expect(page.locator("h1")).to_be_visible()
     expect(page.locator("nav")).to_be_visible()
diff --git a/examples/instrument.py b/examples/instrument.py
@@ -6,6 +6,7 @@
 """
 
 from pyinstrument import Profiler
+from starlette.middleware.base import RequestResponseEndpoint
 
 import air
 from air import Children, Html
@@ -14,7 +15,7 @@
 
 
 @app.middleware("http")
-async def profile_request(request: air.Request, call_next):
+async def profile_request(request: air.Request, call_next: RequestResponseEndpoint):
     profiling = request.query_params.get("profile", False)
     if profiling:
         profiler = Profiler()
diff --git a/examples/mvpcss_hxboost.py b/examples/mvpcss_hxboost.py
@@ -4,7 +4,7 @@
 
 
 @app.page
-async def index(is_htmx=air.is_htmx_request):
+async def index(*, is_htmx: bool = air.is_htmx_request):
     return air.layouts.mvpcss(
         air.Title("Home"),
         air.Article(
@@ -15,7 +15,7 @@ async def index(is_htmx=air.is_htmx_request):
 
 
 @app.page
-async def dashboard(is_htmx=air.is_htmx_request):
+async def dashboard(*, is_htmx: bool = air.is_htmx_request):
     return air.layouts.mvpcss(
         air.Title("Dashboard"),
         air.Article(air.H1("Dashboard"), air.P(air.A("Go home", href="/")), hx_boost="true"),
diff --git a/examples/src/background__BackgroundTasks.py b/examples/src/background__BackgroundTasks.py
@@ -5,7 +5,7 @@
 app = air.Air()
 
 
-def write_notification(email: str, message=""):
+def write_notification(email: str, message: str = "") -> None:
     with pathlib.Path("log.txt").open(mode="w") as email_file:
         content = f"notification for {email}: {message}"
         email_file.write(content)
diff --git a/examples/src/forms__AirForm__widget.py b/examples/src/forms__AirForm__widget.py
@@ -1,3 +1,7 @@
+from collections.abc import Sequence
+
+from pydantic import BaseModel
+
 import air
 from air.forms import default_form_widget
 
@@ -12,7 +16,14 @@ class ContactModel(air.AirModel):
     message: str
 
 
-def contact_widget(*, model, data, errors, includes):
+def contact_widget(
+    *,
+    model: type[BaseModel],
+    data: dict | None = None,
+    errors: list | None = None,
+    includes: Sequence[str] | None = None,
+):
+
     base_html = default_form_widget(
         model=model,
         data=data,
diff --git a/examples/src/models__AirModel__to_form.py b/examples/src/models__AirModel__to_form.py
@@ -1,3 +1,7 @@
+from collections.abc import Sequence
+
+from pydantic import BaseModel
+
 import air
 from air.forms import default_form_widget
 
@@ -10,7 +14,12 @@ class ContactModel(air.AirModel):
     phone: str | None = None
 
 
-def custom_widget(model, data=None, errors=None, includes=None):
+def custom_widget(
+    model: type[BaseModel],
+    data: dict | None = None,
+    errors: list | None = None,
+    includes: Sequence[str] | None = None,
+):
     return air.Div(
         air.P("Custom form styling:"),
         air.Raw(default_form_widget(model, data, errors, includes)),
diff --git a/pyproject.toml b/pyproject.toml
@@ -352,7 +352,6 @@ ignore = [
     "PLC0414", # keep explicit alias
     # TODO -> Remove the rules below this line
     "RUF029", # Function is declared `async`, but doesn't `await` or use `async` features.
-    "ANN001", # https://docs.astral.sh/ruff/rules/missing-type-function-argument
     "ANN201", # https://docs.astral.sh/ruff/rules/missing-return-type-undocumented-public-function
     "ANN202", # https://docs.astral.sh/ruff/rules/missing-return-type-private-function
     "ANN401", # https://docs.astral.sh/ruff/rules/any-type
diff --git a/src/air/background.py b/src/air/background.py
@@ -20,7 +20,7 @@ class BackgroundTasks(FastAPIBackgroundTasks):
         app = air.Air()
 
 
-        def write_notification(email: str, message=""):
+        def write_notification(email: str, message: str = "") -> None:
             with pathlib.Path("log.txt").open(mode="w") as email_file:
                 content = f"notification for {email}: {message}"
                 email_file.write(content)
diff --git a/src/air/forms.py b/src/air/forms.py
@@ -189,6 +189,10 @@ def widget(self) -> Callable:
 
         Example:
 
+            from collections.abc import Sequence
+
+            from pydantic import BaseModel
+
             import air
             from air.forms import default_form_widget
 
@@ -203,7 +207,14 @@ class ContactModel(air.AirModel):
                 message: str
 
 
-            def contact_widget(*, model, data, errors, includes):
+            def contact_widget(
+                *,
+                model: type[BaseModel],
+                data: dict | None = None,
+                errors: list | None = None,
+                includes: Sequence[str] | None = None,
+            ):
+
                 base_html = default_form_widget(
                     model=model,
                     data=data,
diff --git a/src/air/layouts.py b/src/air/layouts.py
@@ -6,17 +6,17 @@
 from .tags.types import HEAD_TAG_TYPES, AttributeType
 
 
-def filter_body_tags(tags) -> list:
+def filter_body_tags(tags: tuple) -> list:
     """Given a list of tags, only list the ones that belong in body of an HTML document."""
     return [t for t in tags if not isinstance(t, HEAD_TAG_TYPES)]
 
 
-def filter_head_tags(tags) -> list:
+def filter_head_tags(tags: tuple) -> list:
     """Given a list of tags, only list the ones that belong in head of an HTML document."""
     return [t for t in tags if isinstance(t, HEAD_TAG_TYPES)]
 
 
-def _header(tags) -> Header | str:
+def _header(tags: tuple | list) -> Header | str:
     """Extracts the air.Header tag from a set of tags."""
     for tag in tags:
         if isinstance(tag, Header):
diff --git a/src/air/middleware.py b/src/air/middleware.py
@@ -24,7 +24,7 @@ class SessionMiddleware(StarletteSessionMiddleware):
         import air
 
         app = air.Air()
-        app.add_middleware(air.SessionMiddleware, secret_key="change-me")
+        app.add_middleware(air.SessionMiddleware, secret_key="change-me")  # ty: ignore[invalid-argument-type]
 
 
         @app.page
diff --git a/src/air/models.py b/src/air/models.py
@@ -36,6 +36,10 @@ def to_form(
 
         Example:
 
+            from collections.abc import Sequence
+
+            from pydantic import BaseModel
+
             import air
             from air.forms import default_form_widget
 
@@ -48,7 +52,12 @@ class ContactModel(air.AirModel):
                 phone: str | None = None
 
 
-            def custom_widget(model, data=None, errors=None, includes=None):
+            def custom_widget(
+                model: type[BaseModel],
+                data: dict | None = None,
+                errors: list | None = None,
+                includes: Sequence[str] | None = None,
+            ):
                 return air.Div(
                     air.P("Custom form styling:"),
                     air.Raw(default_form_widget(model, data, errors, includes)),
diff --git a/tests/benchmarks/test_html_rendering_benchmark.py b/tests/benchmarks/test_html_rendering_benchmark.py
@@ -8,6 +8,7 @@
 from pathlib import Path
 from unittest.mock import Mock
 
+from pytest_benchmark.fixture import BenchmarkFixture
 from starlette.datastructures import URL
 from starlette.requests import Request
 from starlette.templating import _TemplateResponse
@@ -73,7 +74,7 @@ def create_complex_page_with_jinja(jinja_renderer: JinjaRenderer, mock_request:
     return jinja_renderer(mock_request, "complex_page.html", context=context)
 
 
-def test_air_tags_vs_jinja_rendering_benchmark(benchmark) -> None:
+def test_air_tags_vs_jinja_rendering_benchmark(benchmark: BenchmarkFixture) -> None:
     """Benchmark Air Tags vs Jinja2 template rendering for equivalent HTML.
 
     This tests the performance of Air's tag-based approach against traditional template rendering.
@@ -141,7 +142,7 @@ def render_with_jinja() -> _TemplateResponse:
         benchmark(render_with_air_tags)
 
 
-def test_simple_air_tags_rendering_benchmark(benchmark) -> None:
+def test_simple_air_tags_rendering_benchmark(benchmark: BenchmarkFixture) -> None:
     """Benchmark simple Air Tags rendering for baseline performance."""
 
     def render_simple_page() -> str:
diff --git a/tests/benchmarks/test_jinja_rendering_benchmark.py b/tests/benchmarks/test_jinja_rendering_benchmark.py
@@ -8,14 +8,15 @@
 from pathlib import Path
 from unittest.mock import Mock
 
+from pytest_benchmark.fixture import BenchmarkFixture
 from starlette.datastructures import URL
 from starlette.requests import Request
 from starlette.templating import _TemplateResponse
 
 from air.templating import JinjaRenderer
 
 
-def test_jinja_complex_page_rendering_benchmark(benchmark) -> None:
+def test_jinja_complex_page_rendering_benchmark(benchmark: BenchmarkFixture) -> None:
     """Benchmark Jinja2 template rendering for complex HTML structure."""
 
     template_content = """<html>
diff --git a/tests/benchmarks/test_memory_tag_cleanup.py b/tests/benchmarks/test_memory_tag_cleanup.py
@@ -90,7 +90,7 @@ def test_nested_tag_memory_efficiency() -> None:
     tracemalloc.start()
 
     # Create deeply nested structure
-    def create_nested_structure(depth=10) -> Div | Span:
+    def create_nested_structure(depth: int = 10) -> Div | Span:
         if depth == 0:
             return air.Span("Deep content", class_="leaf")
 
diff --git a/tests/benchmarks/test_tag_creation_benchmark.py b/tests/benchmarks/test_tag_creation_benchmark.py
@@ -4,10 +4,12 @@
 to run and save/compare results over time.
 """
 
+from pytest_benchmark.fixture import BenchmarkFixture
+
 import air
 
 
-def test_create_tags_benchmark(benchmark) -> None:
+def test_create_tags_benchmark(benchmark: BenchmarkFixture) -> None:
     """Benchmark creating a number of `air.A` tag objects.
 
     The `benchmark` fixture will run the callable multiple times and report
diff --git a/tests/components.py b/tests/components.py
@@ -1,5 +1,5 @@
 import air
 
 
-def index(title, content) -> air.Html:
+def index(title: str, content: str) -> air.Html:
     return air.Html(air.Title(title), air.H1(content))
diff --git a/tests/scripts/test_copy_src_example_to_callable.py b/tests/scripts/test_copy_src_example_to_callable.py
diff --git a/tests/scripts/test_missing_examples.py b/tests/scripts/test_missing_examples.py
diff --git a/tests/test_exceptions.py b/tests/test_exceptions.py
diff --git a/tests/test_forms.py b/tests/test_forms.py
diff --git a/tests/test_templating.py b/tests/test_templating.py
