Modernize GUI

Note: Work in Progress for now
Matches jenkinsci/kubernetes-plugin#1443 and jenkinsci/azure-vm-agents-plugin#493

- Split agent templates into multiple pages.
- Fix several usability issues with validateButtons and other special
  page elements.
- Allow template list to be reordered.
- Added proper breadcrumb navigation for the new pages and got rid of
  sidepanel for those.

Author: felfert

pom.xml

@@ -387,6 +387,19 @@ limitations under the License.
         </configuration>
       </plugin>
 
+      <plugin>
+        <groupId>com.diffplug.spotless</groupId>
+        <artifactId>spotless-maven-plugin</artifactId>
+        <configuration>
+          <pom>
+            <includes>
+              <!-- Don't touch my pom.xml! -->
+              <include>/dev/null</include>
+            </includes>
+          </pom>
+        </configuration>
+      </plugin>
+
     </plugins>
   </build>
 

src/main/java/jenkins/plugins/jclouds/blobstore/BlobStoreProfile.java

@@ -59,7 +59,6 @@
 import org.kohsuke.stapler.AncestorInPath;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.QueryParameter;
-import org.kohsuke.stapler.interceptor.RequirePOST;
 import org.kohsuke.stapler.verb.POST;
 
 import org.kohsuke.accmod.Restricted;
@@ -323,7 +322,7 @@ public ListBoxModel doFillProviderNameItems(@AncestorInPath ItemGroup context) {
             return m;
         }
 
-        @RequirePOST
+        @POST
         public FormValidation doTestConnection(@QueryParameter("providerName") final String provider,
                @QueryParameter("credentialsId") final String credId,
                @QueryParameter("endPointUrl") final String url,
@@ -344,7 +343,7 @@ public FormValidation doTestConnection(@QueryParameter("providerName") final Str
             return res;
         }
 
-        @RequirePOST
+        @POST
         public ListBoxModel doFillLocationIdItems(@QueryParameter String providerName,
                 @QueryParameter String credentialsId,
                 @QueryParameter String endPointUrl) {
@@ -367,7 +366,7 @@ public ListBoxModel doFillLocationIdItems(@QueryParameter String providerName,
             return m;
         }
 
-        @RequirePOST
+        @POST
         public FormValidation doValidateLocationId(@QueryParameter("providerName") final String provider,
                 @QueryParameter("credentialsId") final String credId,
                 @QueryParameter("endPointUrl") final String url,

src/main/java/jenkins/plugins/jclouds/blobstore/BlobStorePublisher.java

@@ -35,7 +35,7 @@
 import org.kohsuke.stapler.AncestorInPath;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.StaplerRequest2;
-import org.kohsuke.stapler.interceptor.RequirePOST;
+import org.kohsuke.stapler.verb.POST;
 
 import org.jclouds.rest.AuthorizationException;
 
@@ -297,7 +297,7 @@ public boolean isApplicable(Class<? extends AbstractProject> aClass) {
             return profiles != null && !profiles.isEmpty();
         }
 
-        @RequirePOST
+        @POST
         public ListBoxModel doFillProfileNameItems(@AncestorInPath AbstractProject project) {
             if (null == project) {
                 Jenkins.get().checkPermission(Jenkins.ADMINISTER);

src/main/java/jenkins/plugins/jclouds/cli/JCloudsUpdateCloudCommand.java

@@ -84,7 +84,7 @@ protected int run() throws Exception {
             tpl.setCloud(nc);
         }
         if (keep) {
-            nc.templates.addAll(oc.getTemplates());
+            nc.setTemplates(oc.getTemplates());
         }
         Jenkins.get().clouds.replace(oc, nc);
         return 0;

src/main/java/jenkins/plugins/jclouds/compute/InstancesToRun.java

@@ -32,7 +32,7 @@
 import org.kohsuke.stapler.AncestorInPath;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.QueryParameter;
-import org.kohsuke.stapler.interceptor.RequirePOST;
+import org.kohsuke.stapler.verb.POST;
 
 public final class InstancesToRun extends AbstractDescribableImpl<InstancesToRun> implements Serializable {
 
@@ -81,7 +81,7 @@ public String defaultCloudName() {
             return "";
         }
 
-        @RequirePOST
+        @POST
         public ListBoxModel doFillCloudNameItems(@AncestorInPath AbstractProject project) {
             if (null == project) {
                 Jenkins.get().checkPermission(Jenkins.ADMINISTER);
@@ -100,7 +100,7 @@ public ListBoxModel doFillCloudNameItems(@AncestorInPath AbstractProject project
             return m;
         }
 
-        @RequirePOST
+        @POST
         public ListBoxModel doFillTemplateNameItems(@AncestorInPath AbstractProject project, @QueryParameter("cloudName") String cname) {
             if (null == project) {
                 Jenkins.get().checkPermission(Jenkins.ADMINISTER);