Fix presence validator when param value is false

Author: felipefava

lib/request_params_validation/definitions/param.rb

@@ -1,5 +1,4 @@
 require 'request_params_validation/params'
-require 'request_params_validation/exceptions/definitions_errors'
 
 module RequestParamsValidation
   module Definitions

lib/request_params_validation/engine.rb

@@ -6,12 +6,12 @@ class Engine < ::Rails::Engine
     isolate_namespace RequestParamsValidation
 
     initializer 'request_params_validation.load_definitions' do
-      RequestParamsValidation::Definitions.load_all
+      Definitions.load_all
     end
 
     initializer 'request_params_validation.add_helpers' do
       ActiveSupport.on_load :action_controller do
-        include RequestParamsValidation::Helpers
+        include Helpers
       end
     end
   end

lib/request_params_validation/params/validators/presence.rb

@@ -5,7 +5,7 @@ module Presence
         def validate_presence!
           not_present = param.allow_blank ? value.nil? : value.blank?
 
-          raise_error(:on_missing_parameter) if not_present
+          raise_error(:on_missing_parameter) if not_present && value != false
         end
       end
     end

request_params_validation.gemspec

@@ -8,15 +8,15 @@ Gem::Specification.new do |spec|
   spec.version       = RequestParamsValidation::VERSION
   spec.authors       = 'Felipe Fava'
   spec.email         = 'felipefava5@gmail.com'
-  spec.homepage      = "https://github.com/felipefava/request_params_validation"
+  spec.homepage      = 'https://github.com/felipefava/request_params_validation'
   spec.license       = 'MIT'
 
   spec.summary       = 'Validates rails request params'
   spec.description   = 'It validates request params outside your controller logic in order to ' \
                        'get a clean and nice code, and also helping with the documentation of ' \
                        'the operations.'
 
-  spec.files         = Dir["{lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
+  spec.files         = Dir['{lib}/**/*', 'MIT-LICENSE', 'Rakefile', 'README.md']
 
   spec.add_dependency 'rails', '>= 3'
 end

spec/request_params_validation/validators/presence.rb

@@ -35,6 +35,12 @@
           expect(response.body).to eq(build_error_response(:missing_param, param_key: :key))
         end
 
+        context 'when parameter value is false' do
+          let(:key_value) { false }
+
+          it { expect(response).to have_http_status(200) }
+        end
+
         describe 'custom exception for presence validations' do
           class CustomExceptionOnPresenceValidation < StandardError
             def initialize(_options)

spec/spec_helper.rb

@@ -34,7 +34,7 @@
   # is tagged with `:focus`, all examples get run. RSpec also provides
   # aliases for `it`, `describe`, and `context` that include `:focus`
   # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
-  # config.filter_run_when_matching :focus
+  config.filter_run_when_matching :focus
 
   # Allows RSpec to persist some state between runs in order to support
   # the `--only-failures` and `--next-failure` CLI options. We recommend