[HLSL][NFC] Fix range check in verifyRegisterSpace (llvm#152615)

shafik · web-flow · commit 51bc0c1d6bb9 · 2025-08-08T10:04:34.000-07:00
Static analysis flagged the second part of this range check as always
true. RegisterSpace is uint32_t therefore the max value is 0xFFFFFFFF
and so the first check is sufficient.
diff --git a/llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp b/llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp
@@ -29,7 +29,7 @@ bool verifyRegisterValue(uint32_t RegisterValue) {
 // This Range is reserverved, therefore invalid, according to the spec
 // https://github.com/llvm/wg-hlsl/blob/main/proposals/0002-root-signature-in-clang.md#all-the-values-should-be-legal
 bool verifyRegisterSpace(uint32_t RegisterSpace) {
-  return !(RegisterSpace >= 0xFFFFFFF0 && RegisterSpace <= 0xFFFFFFFF);
+  return !(RegisterSpace >= 0xFFFFFFF0);
 }
 
 bool verifyRootDescriptorFlag(uint32_t Version, uint32_t FlagsVal) {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ bool verifyRegisterValue(uint32_t RegisterValue) {`
`29`	`29`	`// This Range is reserverved, therefore invalid, according to the spec`
`30`	`30`	`// https://github.com/llvm/wg-hlsl/blob/main/proposals/0002-root-signature-in-clang.md#all-the-values-should-be-legal`
`31`	`31`	`bool verifyRegisterSpace(uint32_t RegisterSpace) {`
`32`		`- return !(RegisterSpace >= 0xFFFFFFF0 && RegisterSpace <= 0xFFFFFFFF);`
	`32`	`+ return !(RegisterSpace >= 0xFFFFFFF0);`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`bool verifyRootDescriptorFlag(uint32_t Version, uint32_t FlagsVal) {`