[lldb][nfc] Refactor TestSwiftDemangler to simplify additions

This commit adds the code that generated the mangled names in this test,
and rewrites copy/paste as loops. It also changes how "Node paths"
are checked so that more paths may be added.

Author: felipepiovezan

lldb/source/Plugins/LanguageRuntime/Swift/SwiftLanguageRuntimeNames.cpp

@@ -96,12 +96,17 @@ static bool IsSwiftAsyncFunctionSymbol(swift::Demangle::NodePointer node) {
     return childAtPath(node, Node::Kind::ExplicitClosure);
   }();
 
-  return childAtPath(func_node, {Node::Kind::Type, Node::Kind::FunctionType,
-                                 Node::Kind::AsyncAnnotation}) ||
-         childAtPath(func_node,
-                     {Node::Kind::Type, Node::Kind::DependentGenericType,
-                      Node::Kind::Type, Node::Kind::FunctionType,
-                      Node::Kind::AsyncAnnotation});
+  using Kind = Node::Kind;
+  static const llvm::SmallVector<llvm::SmallVector<Kind>>
+      async_annotation_paths = {
+          {Kind::Type, Kind::FunctionType, Kind::AsyncAnnotation},
+          {Kind::Type, Kind::DependentGenericType, Kind::Type,
+           Kind::FunctionType, Kind::AsyncAnnotation},
+      };
+  return llvm::any_of(async_annotation_paths,
+                      [func_node](llvm::ArrayRef<Kind> path) {
+                        return childAtPath(func_node, path);
+                      });
 }
 
 /// Returns true if closure1 and closure2 have the same number, type, and

lldb/unittests/Symbol/TestSwiftDemangler.cpp

@@ -86,6 +86,35 @@ TEST(TestSwiftDemangleAsyncNames, BasicAsync) {
   CheckFuncletNumbersAreARange(generic_funclets);
 }
 
+// The funclets below are created from this program:
+// swiftc -g -Onone test.swift -o - -emit-ir -module-name a \
+// | grep "define.*sayHello"
+// func work() async {}
+// func sayHello() async {
+//   let closure: (Any) async -> () = { _ in
+//     print("hello")
+//     await work()
+//     print("hello")
+//
+//     let inner_closure: (Any) async -> () = { _ in
+//       print("hello")
+//       await work()
+//       print("hello")
+//     }
+//     await inner_closure(10)
+//     print("hello")
+//
+//     let inner_closure2: (Any) async -> () = { _ in
+//       print("hello")
+//       await work()
+//       print("hello")
+//     }
+//
+//     await inner_closure2(10)
+//     print("hello")
+//   }
+//   await closure(10)
+// }
 TEST(TestSwiftDemangleAsyncNames, ClosureAsync) {
   // These are all async closures
   SmallVector<StringRef> nested1_funclets = {
@@ -116,34 +145,30 @@ TEST(TestSwiftDemangleAsyncNames, ClosureAsync) {
       "$s1a18myNonAsyncFunctionyyFyyYacfU_SiypYacfU_SSypYacfU0_TQ1_",
       "$s1a18myNonAsyncFunctionyyFyyYacfU_SiypYacfU_SSypYacfU0_TY2_"};
 
-  for (StringRef async_name : llvm::concat<StringRef>(
-           nested1_funclets, nested2_funclets1, nested2_funclets2,
-           nested2_funclets_top_not_async)) {
-    EXPECT_TRUE(IsSwiftMangledName(async_name)) << async_name;
-    EXPECT_TRUE(IsAnySwiftAsyncFunctionSymbol(async_name)) << async_name;
-  }
+  SmallVector<ArrayRef<StringRef>, 0> funclet_groups = {
+      nested1_funclets,
+      nested2_funclets1,
+      nested2_funclets2,
+      nested2_funclets_top_not_async,
+  };
+
+  for (ArrayRef<StringRef> funclet_group : funclet_groups)
+    for (StringRef async_name : funclet_group) {
+      EXPECT_TRUE(IsSwiftMangledName(async_name)) << async_name;
+      EXPECT_TRUE(IsAnySwiftAsyncFunctionSymbol(async_name)) << async_name;
+    }
+
+  for (ArrayRef<StringRef> funclet_group : funclet_groups)
+    CheckGroupOfFuncletsFromSameFunction(funclet_group);
+
+  for (ArrayRef<StringRef> funclet_group1 : funclet_groups)
+    for (ArrayRef<StringRef> funclet_group2 : funclet_groups)
+      if (funclet_group1.data() != funclet_group2.data())
+        CheckGroupOfFuncletsFromDifferentFunctions(funclet_group1,
+                                                   funclet_group2);
 
-  CheckGroupOfFuncletsFromSameFunction(nested1_funclets);
-  CheckGroupOfFuncletsFromSameFunction(nested2_funclets1);
-  CheckGroupOfFuncletsFromSameFunction(nested2_funclets2);
-  CheckGroupOfFuncletsFromSameFunction(nested2_funclets_top_not_async);
-
-  CheckGroupOfFuncletsFromDifferentFunctions(nested1_funclets,
-                                             nested2_funclets1);
-  CheckGroupOfFuncletsFromDifferentFunctions(nested1_funclets,
-                                             nested2_funclets2);
-  CheckGroupOfFuncletsFromDifferentFunctions(nested1_funclets,
-                                             nested2_funclets_top_not_async);
-  CheckGroupOfFuncletsFromDifferentFunctions(nested2_funclets1,
-                                             nested2_funclets2);
-  CheckGroupOfFuncletsFromDifferentFunctions(nested2_funclets1,
-                                             nested2_funclets_top_not_async);
-  CheckGroupOfFuncletsFromDifferentFunctions(nested2_funclets2,
-                                             nested2_funclets_top_not_async);
-  CheckFuncletNumbersAreARange(nested1_funclets);
-  CheckFuncletNumbersAreARange(nested2_funclets1);
-  CheckFuncletNumbersAreARange(nested2_funclets2);
-  CheckFuncletNumbersAreARange(nested2_funclets_top_not_async);
+  for (ArrayRef<StringRef> funclet_group : funclet_groups)
+    CheckFuncletNumbersAreARange(funclet_group);
 }
 
 TEST(TestSwiftDemangleAsyncNames, StaticAsync) {