add tests for option validation

Author: felixheck

test/cache.spec.js

@@ -1,13 +1,13 @@
 const test = require('ava')
-const { getServer } = require('./_helpers')
+const helpers = require('./_helpers')
 const cache = require('../src/cache')
 
 test.afterEach('reset cache', () => {
   cache.reset()
 })
 
 test.cb.serial('just create one instance – object', (t) => {
-  getServer(false, (server) => {
+  helpers.getServer(false, (server) => {
     const cch1 = cache.init(server, { segment: 'foo' })
     const cch2 = cache.init(server, { segment: 'foo' })
 
@@ -19,7 +19,7 @@ test.cb.serial('just create one instance – object', (t) => {
 })
 
 test.cb.serial('just create one instance – boolean', (t) => {
-  getServer(false, (server) => {
+  helpers.getServer(false, (server) => {
     const cch1 = cache.init(server, false)
     const cch2 = cache.init(server, false)
 
@@ -31,7 +31,7 @@ test.cb.serial('just create one instance – boolean', (t) => {
 })
 
 test.cb.serial('set and get value', (t) => {
-  getServer(false, (server) => {
+  helpers.getServer(false, (server) => {
     cache.init(server, { segment: 'foo' })
     cache.set('bar', 42, 10000)
 
@@ -44,7 +44,7 @@ test.cb.serial('set and get value', (t) => {
 })
 
 test.cb.serial('set and get value – no cache', (t) => {
-  getServer(false, (server) => {
+  helpers.getServer(false, (server) => {
     cache.init(server, false)
     cache.set('bar', 42, 10000)
 
@@ -57,7 +57,7 @@ test.cb.serial('set and get value – no cache', (t) => {
 })
 
 test.cb.serial('set and get value – expired', (t) => {
-  getServer(false, (server) => {
+  helpers.getServer(false, (server) => {
     cache.init(server, { segment: 'foo' })
     cache.set('bar', 42, 100)
 

test/fixtures/index.js

@@ -5,6 +5,19 @@ const introspectPath = '/protocol/openid-connect/token/introspect'
 const realmUrl = `${baseUrl}${realmPath}`
 const clientId = 'foobar'
 const secret = '1234-bar-4321-foo'
+const publicKey = `-----BEGIN RSA PUBLIC KEY-----
+MIICCgKCAgEAur96MoQa/blg5eJFqmN//V4oQjKaBJl6KEvWSGAVgRm2PsnFKzCJ
+K9aJrUjETS473/x6fAHXyF5QKun6avNxpWs2VzwlO4t8Bi2EpSW2w0led2OzR/MF
+CYUX1Bg00OXLmdh0kvemABHXSOL4Zs4nN95rr77JsdG6ntylWmtnZlofySwLjFrX
+B2JFpunl4n7eF7y8vD4Zyycvi+xl+OuMA6qomLQmfIDF0qJh0QMt/xh6CB4ooK5a
+Fy6VHORU5gS6MoSgJ78ZPhqmKayRd6U0rhDOq7bWiVykktTPdB1X/YlMbQHonyqZ
+0z2sh7e7olroUdE1FsDi0SdxV2Zzvff8IIPSGT74gQuaU4buoVUpMjSdXDfJw9m4
+i/mhsZwX1/MUU8Oq1AsBHdgTkNVaVwFc6Z7AqJSGW/mxMKQqspOr+/BAM8pnw5BC
+R/RnZBJfMjAYiSh6rVYuEWUBBLgZWIRNAMyRwS8OtWxADfOBtVwn8fmw8schro9X
+D17VcqTdjlS1Mkr73ZoD1GagWZvuSOaz2P0PhnfapRUF1KkbjjnbyzLpfT8Mgovv
+xBQJDIcRYL5oetXu//V5rNAr0na4zMBkPOi3ArpFp+Z4YKulYmSEG//216rLmzjl
+WKEkH1OK39jddDrMTidlxDKY+THheyQBPZ6pFfbKEM5281glYjkeQpECAwEAAQ==
+-----END RSA PUBLIC KEY-----`
 
 /**
  * @type Object
@@ -25,6 +38,7 @@ const clientConfig = {
  * Common attributes
  */
 const common = Object.assign({}, clientConfig, {
+  publicKey,
   baseUrl,
   token,
   realmPath,

test/index.spec.js

@@ -1,8 +1,8 @@
-const test = require('ava')
 const nock = require('nock')
-const cache = require('../src/cache')
+const test = require('ava')
 const helpers = require('./_helpers')
 const fixtures = require('./fixtures')
+const cache = require('../src/cache')
 
 test.afterEach('reset instances and prototypes', () => {
   cache.reset()

test/token.spec.js

@@ -1,6 +1,6 @@
 const test = require('ava')
-const token = require('../src/token')
 const fixtures = require('./fixtures')
+const token = require('../src/token')
 
 test('enable multiple instances', (t) => {
   const tkn1 = token('bearer a.b.c')

test/utils.spec.js

@@ -1,6 +1,7 @@
-const test = require('ava')
 const boom = require('boom')
+const test = require('ava')
 const helpers = require('./_helpers')
+const fixtures = require('./fixtures')
 const utils = require('../src/utils')
 
 test('get boom error with default message', (t) => {
@@ -113,12 +114,81 @@ test('throw error if options are invalid – secret', (t) => {
   })
 })
 
+test('throw error if options are invalid – publicKey', (t) => {
+  const invalids = [
+    null,
+    NaN,
+    '',
+    'foobar',
+    fixtures.common.baseUrl,
+    42,
+    true,
+    false,
+    [],
+    new RegExp(),
+    {}
+  ]
+
+  t.plan(invalids.length)
+
+  invalids.forEach((invalid) => {
+    t.throws(() => utils.verify(helpers.getOptions({
+      secret: undefined,
+      publicKey: invalid
+    })), Error, helpers.log('publicKey', invalid))
+  })
+})
+
+test('throw error if options are invalid – verifyOpts', (t) => {
+  const invalids = [
+    null,
+    NaN,
+    '',
+    'foobar',
+    fixtures.common.baseUrl,
+    42,
+    true,
+    false,
+    [],
+    { ignoreExpiration: true },
+    { ignoreNotBefore: true }
+  ]
+
+  t.plan(invalids.length)
+
+  invalids.forEach((invalid) => {
+    t.throws(() => utils.verify(helpers.getOptions({
+      secret: undefined,
+      publicKey: fixtures.common.publicKey,
+      verifyOpts: invalid
+    })), Error, helpers.log('publicKey', invalid))
+  })
+})
+
+test('throw error if options are invalid – publicKey/secret conflict', (t) => {
+  t.throws(() => utils.verify(helpers.getOptions({
+    secret: undefined,
+    publicKey: undefined
+  })), Error, 'publicKey/secret: both undefined')
+
+  t.throws(() => utils.verify(helpers.getOptions({
+    publicKey: fixtures.common.publicKey
+  })), Error, 'publicKey/secret: both defined')
+})
+
+test('throw error if options are invalid – verifyOpts/secret conflict', (t) => {
+  t.throws(() => utils.verify(helpers.getOptions({
+    verifyOpts: {}
+  })), Error, 'verifyOpts/secret: both defined')
+})
+
 test('throw error if options are invalid – cache', (t) => {
   const invalids = [
     null,
     NaN,
     '',
     'foobar',
+    fixtures.common.baseUrl,
     42,
     []
   ]
@@ -138,6 +208,7 @@ test('throw error if options are invalid – userInfo', (t) => {
     NaN,
     '',
     'foobar',
+    fixtures.common.baseUrl,
     42,
     true,
     false,
@@ -183,3 +254,29 @@ test('throw no error if options are valid', (t) => {
       Error, helpers.log('valid', valid))
   })
 })
+
+test('throw no error if options are valid', (t) => {
+  const valids = [
+    {},
+    { verifyOpts: undefined },
+    { verifyOpts: {} },
+    { verifyOpts: { audience: 'foobar' } },
+    { cache: {} },
+    { cache: { segment: 'foobar' } },
+    { cache: true },
+    { cache: false },
+    { userInfo: [] },
+    { userInfo: ['string'] }
+  ]
+
+  t.plan(valids.length)
+
+  valids.forEach((valid) => {
+    t.notThrows(
+      () => utils.verify(helpers.getOptions(Object.assign({
+        secret: undefined,
+        publicKey: fixtures.common.publicKey
+      }, valid))),
+      Error, helpers.log('valid with publicKey', valid))
+  })
+})