move utils to fp

Author: felixheck

src/index.js

@@ -88,15 +88,15 @@ function handleKeycloakValidation (tkn, reply) {
  */
 function validate (field, reply) {
   const tkn = token(field)
-  fakeReply(reply)
+  const done = fakeReply(reply)
 
   if (!tkn) {
-    return reply(error('unauthorized', error.msg.missing))
+    return done(error('unauthorized', error.msg.missing))
   }
 
   cache.get(tkn.get(), (err, cached) => {
     const isCached = cached && !err
-    isCached ? reply.continue(cached) : handleKeycloakValidation(tkn, reply)
+    isCached ? done.continue(cached) : handleKeycloakValidation(tkn, done)
   })
 }
 

src/utils.js

@@ -89,11 +89,14 @@ error.msg = {
  * error-first but error-less `continue` method.
  *
  * @param {Function} reply
+ * @returns {Function} The decorated function
  */
 function fakeReply (reply) {
   if (!reply.continue) {
     reply.continue = reply.bind(undefined, null)
   }
+
+  return reply
 }
 
 module.exports = {

test/utils.spec.js

@@ -25,18 +25,21 @@ test('get boom error with error message', (t) => {
 
 test('decorate callback function with `continue`', (t) => {
   const mockFn = function () {}
+  const fake = utils.fakeReply(mockFn)
 
-  utils.fakeReply(mockFn)
   t.truthy(mockFn.continue)
+  t.truthy(fake.continue)
+  t.deepEqual(mockFn, fake)
 })
 
 test('ignore callback function with exsting `continue`', (t) => {
   const mockFn = function () {}
   mockFn.continue = 'foo'
+  const fake = utils.fakeReply(mockFn)
 
-  utils.fakeReply(mockFn)
-  t.truthy(mockFn.continue)
-  t.is(mockFn.continue, 'foo')
+  t.truthy(fake.continue)
+  t.is(fake.continue, 'foo')
+  t.deepEqual(mockFn, fake)
 })
 
 test('throw error if options are empty', (t) => {