Skip to content

Commit e41050c

Browse files
committed
[Test] Simplify C++ header imports
We previously explicitly imported all the C++ headers. This served to verify that the YAML produced the correct outputs. We also do this in Python though, so this is really mostly testing TraitGen. We have a rule of thumb that we don't re-test auto-generated code, and the C++ tooling requirements have been noted to form a barrier to entry to contributors who may work mostly in the Python world. As, assuming we trust TraitGen, all generated headers are still imported by the package header, this commit removes the explicit imports of individual trait headers. This means we should still test that all shipping headers are syntax correct. Signed-off-by: Tom Cowland <[email protected]>
1 parent d7a60db commit e41050c

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

tests/cpp/test.cpp

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,9 @@
11
// SPDX-License-Identifier: Apache-2.0
22
// Copyright 2022 The Foundry Visionmongers Ltd
33

4-
// Include all headers to test they are where we expect and can be
5-
// compiled.
4+
// Include all headers to test they can be compiled.
65

76
#include <openassetio_mediacreation/openassetio_mediacreation.hpp>
8-
#include <openassetio_mediacreation/traits/content.hpp>
9-
#include <openassetio_mediacreation/traits/content/LocatableContentTrait.hpp>
10-
#include <openassetio_mediacreation/traits/identity/DisplayNameTrait.hpp>
11-
#include <openassetio_mediacreation/traits/managementPolicy.hpp>
12-
#include <openassetio_mediacreation/traits/managementPolicy/ManagedTrait.hpp>
13-
#include <openassetio_mediacreation/traits/managementPolicy/ResolvesFutureEntitiesTrait.hpp>
14-
#include <openassetio_mediacreation/traits/traits.hpp>
157

168
using namespace openassetio_mediacreation;
179

0 commit comments

Comments
 (0)