You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+6-1Lines changed: 6 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -37,7 +37,10 @@ These labels are used to keep track of what still needs to be done for an issue
37
37
***Request changes:** There are parts of the code that you think should be changed, and/or you have questions that need to be clarified.
38
38
***Approve:** You think this PR is ready to go. This label will be removed once a PR has at least one approving review and none requesting changes (or the reviewers who requested changes have gone inactive).
39
39
***Needs Testing:** This label is given to every new PR. Someone (does not have to be a dev team member) should make sure the PR does what it says it does, usually by rolling a seed on the PR branch and either testing relevant parts of the game or checking the generated spoiler log, depending on the nature of the PR. Testing can be done by the PR author, so if you let us know what testing you've done on your PR and/or include screenshots or videos, we may skip adding this label entirely. The extent of testing required depends on how big the PR is; if you're not sure what exactly needs to be tested, ask in the PR thread or on Discord.
40
-
***Under Consideration:** This label is given to every enhancement (new feature) issue/PR. The dev team will decide whether this feature is something we want in the randomizer, usually in one of [our calls](https://wiki.ootrandomizer.com/index.php?title=Dev_team_calls). An issue being accepted doesn't necessarily mean that the dev team will actively work on it though.
40
+
***Under Consideration:** This label is given to every enhancement (new feature) issue/PR. The dev team will decide whether this feature is something we want in the randomizer, usually in one of [our calls](https://wiki.ootrandomizer.com/index.php?title=Dev_team_calls) or a private poll. An issue being accepted doesn't necessarily mean that the dev team will actively work on it though. An enhancement for which a poll is currently open is called “nominated”, and the possible outcomes are called “accepted” (indicated by the label being removed) and “rejected” (with the issue/PR being closed with an explanation). Note that this is independent of code review: an enhancement PR needs to be both accepted and approved to be merged. There are some exceptions where enhancements skip this label:
41
+
* Tournament organizers may request features privately to avoid revealing future tournament settings. In this case, the dev team still decides whether to accept or reject the feature, but the label is skipped if the feature has already been accepted at the time a PR is opened.
42
+
* If a PR is made for an issue that has already been accepted, the PR is accepted as well.
43
+
* Glitches and tricks added to advanced logic by @dotzo or @shirosoluna are preaccepted.
41
44
***Waiting for Author:** This label is given to PRs when changes were requested, e.g. in a code review. It's also given to bug reports when we need more info from the reporter.
42
45
***Waiting for Maintainers:** We need to do something to progress this issue/PR, e.g. make a decision on which way a new feature should work.
43
46
***Waiting for Release:** This PR is otherwise ready to be merged, but we are currently in feature freeze (and this is an enhancement PR) or full freeze, and so we're waiting until after the upcoming release to merge it. See the [Release cycle](#release-cycle) section for details.
@@ -78,4 +81,6 @@ Regular releases of the randomizer roughly follow this schedule:
78
81
* Full freeze also lasts at least one week and may take longer if beta tester activity is low.
79
82
* If no critical issues are found during beta testing, the release is published and any PRs labelled “waiting for release” are merged to start off the next release cycle.
80
83
84
+
The current state of the release cycle is pinned in the #dev-public-talk Discord channel.
85
+
81
86
There may also be hotfix releases which bypass this procedure, e.g. in case of a severe bug that wasn't caught in beta testing or in case of changes to racing presets.
0 commit comments