Merge branch 'main' into issue-1243

Author: ferishili

lib/Models/REST/SeriesClient.php

@@ -77,7 +77,7 @@ private static function getSeriesDC($course_id)
         $publisher   = (string)$inst->name;
         $instructors = $course->getMembers('dozent');
         $instructor  = array_shift($instructors);
-        $contributor = $GLOBALS['UNI_NAME_CLEAN'] ?: 'unbekannt';
+        $contributor = \Config::get()->getValue('UNI_NAME_CLEAN') ?: 'unbekannt';
         $creator     = $instructor['fullname'];
         $language    = 'de';
 

lib/Models/ScheduleHelper.php

@@ -303,17 +303,18 @@ public static function createScheduleEventXML($course_id, $resource_id, $termin_
         }
 
         $contributor = $inst_data['name'];
-        $description = $issue->description;
+        $description = $issue->description ?? null;
         $device = $ca['capture_agent'];
 
         $language = "de";
         $seriesId = $serie['series_id'];
 
-        if (!$issue->title) {
+        if (empty($issue->title)) {
             $name = $course->getName();
             $title = $name . ' ' . sprintf(_('(%s)'), $date->getDatesExport());
-        } else $title = $issue_titles;
-
+        } else {
+            $title = $issue_titles;
+        }
 
         // Additional Metadata
         $abstract = $course->description;
@@ -515,7 +516,7 @@ private static function createEventMetadata($course_id, $resource_id, $config_id
             }
         }
 
-        if (!$issue->title) {
+        if (empty($issue->title)) {
             $course = Seminar::getInstance($course_id);
             $name   = $course->getName();
             $title  = $name . ' ' . sprintf(_('(%s)'), $date->getDatesExport());