Skip to content

Conversation

@bacongobbler
Copy link
Member

All of the repositories changed in this commit have been migrated to the spinframework org.

This coincides with other changes like #1503.

@github-actions
Copy link

🚀 preview deployed successfully to Fermyon Cloud and available at https://fermyon-developer-pr-1521-ewpnloat.fermyon.app

@bacongobbler
Copy link
Member Author

CI will go green once spinframework/spin-go-sdk#21 has been merged.

@vdice
Copy link
Member

vdice commented Apr 10, 2025

Thanks for these updates @bacongobbler.

Question around the updates involving the spin go sdk: With the search/replace approach, URLs are updated to eg github.com/spinframework/spin/sdk/go/v2/http; yet the go sdk has since been broken out to https://github.com/spinframework/spin-go-sdk. Should we update appropriately? eg spinframework/spin/sdk/go/v2 -> spinframework/spin-go-sdk, etc?

@bacongobbler
Copy link
Member Author

Good catch. Yes, the new module name is github.com/spinframework/spin-go-sdk/http so the import paths should be updated to reflect that.

https://github.com/spinframework/spin-go-sdk/blob/f911142cc434d007c25eb03d11057c92a7f322d7/examples/http-outbound/http-to-same-app/main.go#L7

All of the references changed in this commit have been migrated to the
spinframework org.

Signed-off-by: Matthew Fisher <[email protected]>
@vdice vdice force-pushed the bacongobbler/fix-spinframework-references branch from 64f8ab8 to 4538259 Compare April 11, 2025 18:37
@vdice
Copy link
Member

vdice commented Apr 11, 2025

Good catch. Yes, the new module name is github.com/spinframework/spin-go-sdk/http so the import paths should be updated to reflect that.

Actually, as I was revising import paths, I realized I shouldn't touch the docs in the older spin/v1 and spin/v2 folders, since the examples/usage may be particular to the go sdk versions used at the time. So, assuming the older go sdk versions/URLs can still be used (i.e. they aren't broken), we should leave these be.

Then, while updating the current spin/v3 docs, I realized the go templates in the spin repo still reference the v2 version of the go sdk (see also spinframework/spin#3106). That, combined with a current unfamiliarity as to whether examples/usage will need to change when bumping to the new go sdk and the new sdk doesn't yet appear to have a tag or versioned release, I figured we should leave these be until 1. the go templates are updated and 2. we're ready for a first versioned release of the new go sdk (also, perhaps we're waiting for wasip2 support to land) cc @adamreese

Mind you, we're also about to remove all spin/* directories in #1512 😉 so mostly the above applies to the spin documentation in its new home: https://github.com/spinframework/spin-docs

Therefore, I've only rebased this branch to fix the conflicts on main and will merge in its current form. Thanks again!

@vdice vdice merged commit e3f2dd3 into main Apr 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants