Skip to content

Commit 7314761

Browse files
authored
fix(editor): remove unnecessary gitloader from editable docs loader (#4718)
Fixes FER- ## Short description of the changes made ## What was the motivation & context behind this PR? ## How has this PR been tested?
1 parent a8fcb2f commit 7314761

File tree

6 files changed

+5
-14
lines changed

6 files changed

+5
-14
lines changed

packages/commons/docs-loader/src/editable-docs-loader.ts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,7 @@ class EditableDocsLoader implements DocsLoader {
1515
domain: string;
1616
fern_token: string | undefined;
1717

18-
constructor(
19-
docsLoader: DocsLoader,
20-
private gitLoader?: GitLoader
21-
) {
18+
constructor(docsLoader: DocsLoader) {
2219
this.readOnlyDocsLoader = docsLoader;
2320
this.domain = docsLoader.domain;
2421
this.fern_token = docsLoader.fern_token;
@@ -180,14 +177,12 @@ export const createEditableDocsLoader = async ({
180177
host,
181178
encodedDocsUrl,
182179
fernToken,
183-
gitLoader,
184180
forceRevalidate,
185181
branchName
186182
}: {
187183
host: string;
188184
encodedDocsUrl: string;
189185
fernToken?: string;
190-
gitLoader?: GitLoader;
191186
forceRevalidate?: boolean;
192187
branchName?: string;
193188
}) => {
@@ -201,5 +196,5 @@ export const createEditableDocsLoader = async ({
201196
skipAuth: true
202197
});
203198

204-
return new EditableDocsLoader(docsLoader, gitLoader);
199+
return new EditableDocsLoader(docsLoader);
205200
};

packages/fern-dashboard/src/app/[orgName]/(visual-editor)/editor/[docsUrl]/[branch]/[...slug]/@headertabs/page.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export default async function HeaderTabsPage({
2727
docsUrl: parseDocsUrlParam({ docsUrl })
2828
});
2929
// Use cached loader - this will reuse the loader created in layout.tsx
30-
const loader = await getCachedEditableDocsLoader(host, docsUrl, session.accessToken, branch, githubUrl);
30+
const loader = await getCachedEditableDocsLoader(host, docsUrl, session.accessToken, branch);
3131
const layout = await loader.getLayout();
3232

3333
if (layout.tabsPlacement !== "HEADER") {

packages/fern-dashboard/src/app/[orgName]/(visual-editor)/editor/[docsUrl]/[branch]/[...slug]/layout.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export default async function VisualEditorPreviewLayout({
6060
const host = await getHostFromHeaders();
6161

6262
// Use cached loader to prevent duplicate creation across parallel routes
63-
const loader = await getCachedEditableDocsLoader(host, docsUrl, session.accessToken, branch, githubUrl);
63+
const loader = await getCachedEditableDocsLoader(host, docsUrl, session.accessToken, branch);
6464

6565
const [colors, layout, fonts, config, root, unsafe_fullRoot, files, { basePath }] = await Promise.all([
6666
loader.getColors(),

packages/fern-dashboard/src/app/[orgName]/(visual-editor)/editor/[docsUrl]/[branch]/[...slug]/page.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export default async function Page({
4040
});
4141

4242
// Use cached loader - this will reuse the loader created in layout.tsx
43-
const loader = await getCachedEditableDocsLoader(host, docsUrl, session.accessToken, branch, githubUrl);
43+
const loader = await getCachedEditableDocsLoader(host, docsUrl, session.accessToken, branch);
4444

4545
const root = await loader.getRoot();
4646
const navigationSlug = getRootAliasAwareNavigationSlug(slugjoin(slug), root);

packages/fern-dashboard/src/app/services/docs-loader/cachedEditableDocsLoader.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { createEditableDocsLoader } from "@fern-api/docs-loader";
22
import type { DocsLoader } from "@fern-api/docs-server/docs-loader";
33
import { cache } from "react";
44
import type { EncodedDocsUrl } from "@/utils/types";
5-
import { GitHubLoader } from "../github/github-loader";
65

76
/**
87
* Cached version of createEditableDocsLoader to prevent duplicate loader creation
@@ -14,14 +13,12 @@ export const getCachedEditableDocsLoader = cache(
1413
encodedDocsUrl: EncodedDocsUrl,
1514
fernToken: string,
1615
branchName?: string,
17-
githubUrl?: string,
1816
forceRevalidate?: boolean
1917
) => {
2018
return createEditableDocsLoader({
2119
host,
2220
encodedDocsUrl,
2321
fernToken,
24-
gitLoader: githubUrl ? new GitHubLoader(githubUrl) : undefined,
2522
branchName,
2623
forceRevalidate
2724
});

packages/fern-dashboard/src/app/services/docs-loader/preloadEditorData.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ export default async function preloadEditorData(request: {
2828
request.docsUrl,
2929
session.accessToken,
3030
request.branch,
31-
undefined,
3231
true // force revalidate when preloading
3332
);
3433

0 commit comments

Comments
 (0)