fix type issues in untyped components

Author: sbawabe

packages/fern-dashboard/src/app/[orgName]/(homepage)/docs/[docsUrl]/page.tsx

@@ -37,7 +37,7 @@ export default async function Page(props: { params: Promise<{ orgName: Auth0OrgN
     // Start expensive operations in parallel without awaiting
     Promise.all([
         getDocsGithubUrl(docsUrl, session.accessToken),
-        getGitHubAuthState(docsUrl, session.accessToken, orgName, docsUrl, session)
+        getGitHubAuthState(docsUrl, session.accessToken, orgName, session)
     ]);
 
     return (

packages/fern-dashboard/src/app/actions/getDocsGithubMetadata.ts

@@ -3,14 +3,15 @@
 import { fernToken_admin } from "@fern-api/docs-server";
 
 import type { GithubAuthState } from "@/components/docs-page/GithubSourceClient";
+import type { DocsUrl } from "@/utils/types";
 import { getDocsUrlMetadata } from "../api/utils/getDocsUrlMetadata";
 import { type Auth0SessionData, getCurrentSessionOrThrow } from "../services/auth0/getCurrentSession";
 import type { Auth0OrgName } from "../services/auth0/types";
 import { getDocsGithubUrl } from "../services/dal/github/getDocsGithubUrl";
 import { validateGithubRepoAccess } from "../services/dal/github/validators";
 import { getGithubSourceMetadata } from "./getGithubSourceMetadata";
 
-async function getMetadata(encodedDocsUrl: string, session: Auth0SessionData, orgName: Auth0OrgName, docsUrl: string) {
+async function getMetadata(encodedDocsUrl: DocsUrl, session: Auth0SessionData, orgName: Auth0OrgName, docsUrl: string) {
     let githubAuthState: GithubAuthState = {
         validationResult: {
             ok: false,
@@ -84,7 +85,7 @@ async function getMetadata(encodedDocsUrl: string, session: Auth0SessionData, or
     }
 }
 
-export async function getDocsGithubMetadata(docsUrl: string): Promise<{
+export async function getDocsGithubMetadata(docsUrl: DocsUrl): Promise<{
     success: boolean;
     orgName?: Auth0OrgName;
     githubUrl?: string;
@@ -98,7 +99,7 @@ export async function getDocsGithubMetadata(docsUrl: string): Promise<{
             url: decodedUrl,
             token: fernToken_admin() ?? session.accessToken
         });
-        const githubMetadata = await getDocsGithubUrl(decodedUrl, fernToken_admin() ?? session.accessToken);
+        const githubMetadata = await getDocsGithubUrl(docsUrl, fernToken_admin() ?? session.accessToken);
         if (!githubMetadata.success) {
             return { success: false, error: "Failed to fetch github metadata" };
         }
@@ -109,7 +110,7 @@ export async function getDocsGithubMetadata(docsUrl: string): Promise<{
 
         const orgName = docsMetadata.body.org as unknown as Auth0OrgName;
 
-        const metadata = await getMetadata(decodedUrl, session, orgName, decodedUrl);
+        const metadata = await getMetadata(docsUrl, session, orgName, decodedUrl);
         if (!metadata?.success) {
             return { success: false, error: "Failed to fetch metadata" };
         }

packages/fern-dashboard/src/app/actions/getGithubMetadata.ts

@@ -1,6 +1,7 @@
 import "server-only";
 import { cache } from "react";
 import type { GithubAuthState } from "@/components/docs-page/GithubSourceClient";
+import type { DocsUrl } from "@/utils/types";
 import type { Auth0SessionData } from "../services/auth0/getCurrentSession";
 import type { Auth0OrgName } from "../services/auth0/types";
 import { type GetDocsGithubUrlResult, getDocsGithubUrl } from "../services/dal/github/getDocsGithubUrl";
@@ -13,13 +14,12 @@ export type GetGitHubAuthStateResult = GithubAuthState | { success: false; error
 
 export const getGitHubAuthState = cache(
     async (
-        url: string,
+        docsUrl: DocsUrl,
         token: string,
         orgName: Auth0OrgName,
-        docsUrl: string,
         session: Auth0SessionData
     ): Promise<GetGitHubAuthStateResult> => {
-        const urlResult = await getDocsGithubUrl(url, token);
+        const urlResult = await getDocsGithubUrl(docsUrl, token);
         if (!urlResult.success) {
             return { success: false, error: urlResult.error };
         }

packages/fern-dashboard/src/app/services/dal/github/getDocsGithubUrl.ts

@@ -3,6 +3,7 @@ import "server-only";
 import { fernToken_admin } from "@fern-api/docs-server";
 import { cache } from "react";
 import { getDocsUrlMetadata } from "@/app/api/utils/getDocsUrlMetadata";
+import type { DocsUrl } from "@/utils/types";
 
 interface GetDocsGithubUrlSuccess {
     success: true;
@@ -19,7 +20,7 @@ interface GetDocsGithubUrlError {
 
 export type GetDocsGithubUrlResult = GetDocsGithubUrlSuccess | GetDocsGithubUrlError;
 
-export const getDocsGithubUrl = cache(async (url: string, token: string): Promise<GetDocsGithubUrlResult> => {
+export const getDocsGithubUrl = cache(async (url: DocsUrl, token: string): Promise<GetDocsGithubUrlResult> => {
     const docsUrlMetadata = await getDocsUrlMetadata({
         url: decodeURIComponent(url),
         token: fernToken_admin() ?? token

packages/fern-dashboard/src/components/docs-page/FernCliVersion.tsx

@@ -19,7 +19,7 @@ export async function FernCliVersion({ orgName, docsUrl }: { orgName: Auth0OrgNa
     }
     const [githubUrlResult, githubAuthStateResult] = await Promise.all([
         getDocsGithubUrl(docsUrl, session.accessToken),
-        getGitHubAuthState(docsUrl, session.accessToken, orgName, docsUrl, session)
+        getGitHubAuthState(docsUrl, session.accessToken, orgName, session)
     ]);
 
     const githubUrl = githubUrlResult.success ? githubUrlResult.githubUrl : undefined;

packages/fern-dashboard/src/components/docs-page/visual-editor-section/VisualEditorSection.tsx

@@ -27,7 +27,7 @@ export async function VisualEditorSection({
 }) {
     const [githubUrlResult, githubAuthStateResult] = await Promise.all([
         getDocsGithubUrl(docsUrl, session.accessToken),
-        getGitHubAuthState(docsUrl, session.accessToken, orgName, docsUrl, session)
+        getGitHubAuthState(docsUrl, session.accessToken, orgName, session)
     ]);
 
     const githubUrl = githubUrlResult.success ? githubUrlResult.githubUrl : undefined;

packages/fern-dashboard/src/components/web-analytics/WebAnalyticsPage.tsx

@@ -17,7 +17,7 @@ import SelectDate from "./SelectDate";
 import AnalyticsTables from "./Tables";
 
 interface WebAnalyticsPageProps {
-    docsUrl: string;
+    docsUrl: DocsUrl;
 }
 
 export default function WebAnalyticsPage({ docsUrl }: WebAnalyticsPageProps) {