Skip to content

Commit a4dd7ad

Browse files
committed
fix(docs): typescript errors
1 parent 07dc963 commit a4dd7ad

File tree

8 files changed

+16
-2
lines changed

8 files changed

+16
-2
lines changed

packages/fern-dashboard/src/app/[orgName]/(visual-editor)/editor/[docsUrl]/[branch]/[...slug]/@sidebar/PageSidebar.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export default function PageSidebar({
8888
sidebarRootNodeId={found.sidebar?.id}
8989
tabId={found.currentTab?.id}
9090
productId={found.currentProduct?.productId}
91-
productSlug={found.currentProduct?.slug}
91+
productSlug={found.currentProduct?.type === "product" ? found.currentProduct.slug : undefined}
9292
versionId={found.currentVersion?.versionId}
9393
versionSlug={found.currentVersion?.slug}
9494
variantId={found.currentVariant?.variantId}

packages/fern-dashboard/src/app/[orgName]/(visual-editor)/editor/[docsUrl]/[branch]/[...slug]/PageNode.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export default function PageNode(props: PageNode.Props) {
8888
sidebarRootNodeId={found.sidebar?.id}
8989
tabId={found.currentTab?.id}
9090
productId={found.currentProduct?.productId}
91-
productSlug={found.currentProduct?.slug}
91+
productSlug={found.currentProduct?.type === "product" ? found.currentProduct.slug : undefined}
9292
versionId={found.currentVersion?.versionId}
9393
versionSlug={found.currentVersion?.slug}
9494
variantId={found.currentVariant?.variantId}

packages/fern-docs/components/src/navigation/__tests__/NavigationStorage.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ describe("NavigationStorage", () => {
100100
currentTab: undefined,
101101
currentVersion: undefined,
102102
currentProduct: undefined,
103+
currentVariant: undefined,
103104
isCurrentVersionDefault: true,
104105
isCurrentProductDefault: true
105106
}

packages/fern-docs/components/src/navigation/__tests__/NavigationStore.canDirectlyEditDocsYmlNavigation.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ products:
112112
currentTab: undefined,
113113
currentVersion: undefined,
114114
currentProduct: undefined,
115+
currentVariant: undefined,
115116
isCurrentVersionDefault: true,
116117
isCurrentProductDefault: true
117118
},

packages/fern-docs/components/src/navigation/__tests__/NavigationStore.rootNode.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ describe("NavigationStore - rootNode management", () => {
124124
currentTab: undefined,
125125
currentVersion: undefined,
126126
currentProduct: undefined,
127+
currentVariant: undefined,
127128
isCurrentVersionDefault: true,
128129
isCurrentProductDefault: true
129130
},
@@ -183,6 +184,7 @@ describe("NavigationStore - rootNode management", () => {
183184
currentTab: undefined,
184185
currentVersion: undefined,
185186
currentProduct: undefined,
187+
currentVariant: undefined,
186188
isCurrentVersionDefault: true,
187189
isCurrentProductDefault: true
188190
},
@@ -230,6 +232,7 @@ describe("NavigationStore - rootNode management", () => {
230232
currentTab: undefined,
231233
currentVersion: undefined,
232234
currentProduct: undefined,
235+
currentVariant: undefined,
233236
isCurrentVersionDefault: true,
234237
isCurrentProductDefault: true
235238
},
@@ -259,6 +262,7 @@ describe("NavigationStore - rootNode management", () => {
259262
currentTab: undefined,
260263
currentVersion: undefined,
261264
currentProduct: undefined,
265+
currentVariant: undefined,
262266
isCurrentVersionDefault: true,
263267
isCurrentProductDefault: true
264268
},

packages/fern-docs/components/src/navigation/__tests__/NavigationStore.test.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ describe("NavigationStore", () => {
5050
currentTab: undefined,
5151
currentVersion: undefined,
5252
currentProduct: undefined,
53+
currentVariant: undefined,
5354
isCurrentVersionDefault: true,
5455
isCurrentProductDefault: true
5556
}
@@ -85,6 +86,7 @@ describe("NavigationStore", () => {
8586
currentTab: undefined,
8687
currentVersion: undefined,
8788
currentProduct: undefined,
89+
currentVariant: undefined,
8890
isCurrentVersionDefault: true,
8991
isCurrentProductDefault: true
9092
}
@@ -125,6 +127,7 @@ describe("NavigationStore", () => {
125127
currentTab: undefined,
126128
currentVersion: undefined,
127129
currentProduct: undefined,
130+
currentVariant: undefined,
128131
isCurrentVersionDefault: true,
129132
isCurrentProductDefault: true
130133
},
@@ -205,6 +208,7 @@ describe("NavigationStore", () => {
205208
currentTab: undefined,
206209
currentVersion: undefined,
207210
currentProduct: undefined,
211+
currentVariant: undefined,
208212
isCurrentVersionDefault: true,
209213
isCurrentProductDefault: true
210214
}
@@ -236,6 +240,7 @@ describe("NavigationStore", () => {
236240
currentTab: undefined,
237241
currentVersion: undefined,
238242
currentProduct: undefined,
243+
currentVariant: undefined,
239244
isCurrentVersionDefault: true,
240245
isCurrentProductDefault: true
241246
}

packages/fern-docs/components/src/navigation/migrations.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ function migrateV0ToV1(branchName: string, oldData: NavigationSnapshotV0): Navig
9292
: undefined,
9393
currentVersion: clientPageData?.navigationContext?.currentVersion,
9494
currentProduct: clientPageData?.navigationContext?.currentProduct,
95+
currentVariant: undefined,
9596
isCurrentVersionDefault: clientPageData?.navigationContext?.isCurrentVersionDefault ?? false,
9697
isCurrentProductDefault: clientPageData?.navigationContext?.isCurrentProductDefault ?? false
9798
};

packages/fern-docs/components/src/navigation/types.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export type SerializableFoundNode = Pick<
2121
| "currentTab"
2222
| "currentVersion"
2323
| "currentProduct"
24+
| "currentVariant"
2425
| "isCurrentVersionDefault"
2526
| "isCurrentProductDefault"
2627
>;
@@ -35,6 +36,7 @@ export function getSerializableFoundNode(foundNode: FernNavigation.utils.Node.Fo
3536
currentTab: foundNode.currentTab,
3637
currentVersion: foundNode.currentVersion,
3738
currentProduct: foundNode.currentProduct,
39+
currentVariant: foundNode.currentVariant,
3840
isCurrentVersionDefault: foundNode.isCurrentVersionDefault,
3941
isCurrentProductDefault: foundNode.isCurrentProductDefault
4042
};

0 commit comments

Comments
 (0)