fix(docs): remove local cache (#3283)

Author: dsinghvi

servers/fdr/src/app/FdrApplication.ts

@@ -9,7 +9,6 @@ import {
   DocsDefinitionCache,
   DocsDefinitionCacheImpl,
 } from "../services/docs-cache/DocsDefinitionCache";
-import LocalDocsDefinitionStore from "../services/docs-cache/LocalDocsDefinitionStore";
 import RedisDocsDefinitionStore from "../services/docs-cache/RedisDocsDefinitionStore";
 import { LocalRevalidatorServiceImpl } from "../services/revalidator/LocalRevalidatorService";
 import {
@@ -87,7 +86,6 @@ export class FdrApplication {
     this.docsDefinitionCache = new DocsDefinitionCacheImpl(
       this,
       this.dao,
-      new LocalDocsDefinitionStore(),
       this.redisDatastore
     );
 

servers/fdr/src/services/docs-cache/DocsDefinitionCache.ts

@@ -12,7 +12,6 @@ import {
 import { DocsRegistrationInfo } from "../../controllers/docs/v2/getDocsWriteV2Service";
 import { FdrDao } from "../../db";
 import { Semaphore } from "../revalidator/Semaphore";
-import LocalDocsDefinitionStore from "./LocalDocsDefinitionStore";
 import RedisDocsDefinitionStore from "./RedisDocsDefinitionStore";
 
 const DOCS_DOMAIN_REGX = /^([^.\s]+)/;
@@ -66,18 +65,15 @@ export interface CachedDocsResponse {
 }
 
 export class DocsDefinitionCacheImpl implements DocsDefinitionCache {
-  private localDocsCache: LocalDocsDefinitionStore;
   private redisDocsCache: RedisDocsDefinitionStore | undefined;
   private DOCS_WRITE_MONITOR: Record<string, Semaphore> = {};
   private initialized: boolean = false;
 
   constructor(
     private readonly app: FdrApplication,
     private readonly dao: FdrDao,
-    localDocsCache: LocalDocsDefinitionStore,
     redisDocsCache: RedisDocsDefinitionStore | undefined
   ) {
-    this.localDocsCache = localDocsCache;
     this.redisDocsCache = redisDocsCache;
   }
 
@@ -106,7 +102,6 @@ export class DocsDefinitionCacheImpl implements DocsDefinitionCache {
     if (this.redisDocsCache) {
       await this.redisDocsCache.delete({ url });
     }
-    this.localDocsCache.delete({ url });
   }
 
   public async getDocsForUrl({
@@ -228,7 +223,6 @@ export class DocsDefinitionCacheImpl implements DocsDefinitionCache {
     if (this.redisDocsCache) {
       await this.redisDocsCache.set({ url, value });
     }
-    this.localDocsCache.set({ url, value });
   }
 
   private async getDocsForUrlFromCache({
@@ -240,7 +234,7 @@ export class DocsDefinitionCacheImpl implements DocsDefinitionCache {
     if (this.redisDocsCache) {
       record = await this.redisDocsCache.get({ url });
     } else {
-      record = this.localDocsCache.get({ url }) ?? null;
+      record = null;
     }
     if (record != null && record.version !== SEMANTIC_VERSION) {
       return null;