fix(cli, typescript): Fix ts local github generation to match remote generation (#9869)

Author: jsklan

.gitignore

@@ -85,4 +85,6 @@ seed/python-sdk/**/output.prof
 .yarn-cache
 .pnpm-cache
 
-**/vitest.config.ts.*.mjs
+**/vitest.config.ts.*.mjs
+
+.local

generators/base/src/AbstractGeneratorAgent.ts

@@ -72,7 +72,7 @@ export abstract class AbstractGeneratorAgent<GeneratorContext extends AbstractGe
     }): Promise<string> {
         const readmeConfig = this.getReadmeConfig({
             context,
-            remote: this.getRemote(),
+            remote: this.getRemote(context),
             featureConfig: await this.readFeatureConfig(),
             endpointSnippets
         });
@@ -127,17 +127,44 @@ export abstract class AbstractGeneratorAgent<GeneratorContext extends AbstractGe
         return loaded;
     }
 
-    protected getRemote(): FernGeneratorCli.Remote | undefined {
+    protected getRemote(context: GeneratorContext): FernGeneratorCli.Remote | undefined {
         const outputMode = this.config.output.mode.type === "github" ? this.config.output.mode : undefined;
         if (outputMode?.repoUrl != null && outputMode?.installationToken != null) {
             return FernGeneratorCli.Remote.github({
                 repoUrl: outputMode.repoUrl,
                 installationToken: outputMode.installationToken
             });
         }
+
+        try {
+            const githubConfig = this.getGitHubConfig({ context });
+            if (githubConfig.uri != null && githubConfig.token != null) {
+                return FernGeneratorCli.Remote.github({
+                    repoUrl: this.normalizeRepoUrl(githubConfig.uri),
+                    installationToken: githubConfig.token
+                });
+            }
+        } catch (error) {
+            return undefined;
+        }
         return undefined;
     }
 
+    private normalizeRepoUrl(repoUrl: string): string {
+        // If it's already a full URL, return as-is
+        if (repoUrl.startsWith("https://")) {
+            return repoUrl;
+        }
+
+        // If it's in owner/repo format, convert to full GitHub URL
+        if (repoUrl.match(/^[a-zA-Z0-9_-]+\/[a-zA-Z0-9_-]+$/)) {
+            return `https://github.com/${repoUrl}`;
+        }
+
+        // Default: assume it's a GitHub URL and add prefix
+        return `https://github.com/${repoUrl}`;
+    }
+
     private async getFeaturesConfig(): Promise<string> {
         // try to find the features.yml file using the well-known paths
         for (const each of FEATURES_CONFIG_PATHS) {

generators/swift/sdk/src/SwiftGeneratorAgent.ts

@@ -40,7 +40,7 @@ export class SwiftGeneratorAgent extends AbstractGeneratorAgent<SdkGeneratorCont
     }): Promise<string> {
         const readmeConfig = this.getReadmeConfig({
             context,
-            remote: this.getRemote(),
+            remote: this.getRemote(context),
             featureConfig: await this.readFeatureConfig(),
             endpointSnippets
         });

generators/typescript-v2/ast/src/custom-config/TypescriptCustomConfigSchema.ts

@@ -65,7 +65,10 @@ export const TypescriptCustomConfigSchema = z.strictObject({
 
     // deprecated
     timeoutInSeconds: z.optional(z.union([z.literal("infinity"), z.number()])),
-    includeApiReference: z.optional(z.boolean())
+    includeApiReference: z.optional(z.boolean()),
+
+    // internal - license name extracted from custom license file
+    _fernLicenseName: z.optional(z.string())
 });
 
 export type TypescriptCustomConfigSchema = z.infer<typeof TypescriptCustomConfigSchema>;

generators/typescript-v2/browser-compatible-base/src/utils/constructNpmPackage.ts

@@ -1,6 +1,32 @@
 import { FernGeneratorExec } from "@fern-fern/generator-exec-sdk";
 
 import { type NpmPackage } from "../NpmPackage";
+import { PublishInfo } from "../PublishInfo";
+
+export interface constructNpmPackageArgs {
+    packageName?: string;
+    version?: string;
+    repoUrl?: string;
+    publishInfo?: PublishInfo;
+    licenseConfig?: FernGeneratorExec.LicenseConfig;
+    isPackagePrivate: boolean;
+}
+
+export function constructNpmPackageFromArgs(args: constructNpmPackageArgs): NpmPackage | undefined {
+    const { packageName, version, repoUrl, publishInfo, licenseConfig, isPackagePrivate } = args;
+    if (packageName == null || version == null) {
+        return undefined;
+    }
+
+    return {
+        packageName,
+        version,
+        private: isPackagePrivate,
+        publishInfo,
+        license: licenseFromLicenseConfig(licenseConfig),
+        repoUrl: getRepoUrlFromUrl(repoUrl)
+    };
+}
 
 export function constructNpmPackage({
     generatorConfig,
@@ -50,7 +76,10 @@ export function constructNpmPackage({
     }
 }
 
-function getRepoUrlFromUrl(repoUrl: string): string {
+function getRepoUrlFromUrl(repoUrl: string | undefined): string | undefined {
+    if (repoUrl == null) {
+        return undefined;
+    }
     if (repoUrl.startsWith("https://github.com/")) {
         return `github:${removeGitSuffix(repoUrl).replace("https://github.com/", "")}`;
     }
@@ -84,3 +113,11 @@ function removeGitSuffix(repoUrl: string): string {
     }
     return repoUrl;
 }
+
+function licenseFromLicenseConfig(licenseConfig: FernGeneratorExec.LicenseConfig | undefined): string | undefined {
+    return licenseConfig?._visit({
+        basic: (basic) => basic.id,
+        custom: (custom) => `See ${custom.filename}`,
+        _other: () => undefined
+    });
+}

generators/typescript-v2/browser-compatible-base/src/utils/index.ts

@@ -1,2 +1,2 @@
-export { constructNpmPackage } from "./constructNpmPackage";
+export * from "./constructNpmPackage";
 export { getNamespaceExport } from "./getNamespaceExport";

generators/typescript/sdk/cli/src/SdkGeneratorCli.ts

@@ -13,6 +13,8 @@ import {
 } from "@fern-typescript/commons";
 import { GeneratorContext } from "@fern-typescript/contexts";
 import { SdkGenerator } from "@fern-typescript/sdk-generator";
+import { copyFile } from "fs/promises";
+import path from "path";
 
 import { SdkCustomConfig } from "./custom-config/SdkCustomConfig";
 import { SdkCustomConfigSchema } from "./custom-config/schema/SdkCustomConfigSchema";
@@ -251,6 +253,7 @@ export class SdkGeneratorCli extends AbstractGeneratorCli<SdkCustomConfig> {
             pathToSrc: persistedTypescriptProject.getSrcDirectory()
         });
         await writeTemplateFiles(rootDirectory, this.getTemplateVariables(customConfig));
+        await this.writeLicenseFile(config, rootDirectory, generatorContext.logger);
         await this.postProcess(persistedTypescriptProject, customConfig);
 
         return persistedTypescriptProject;
@@ -265,6 +268,45 @@ export class SdkGeneratorCli extends AbstractGeneratorCli<SdkCustomConfig> {
         };
     }
 
+    private async writeLicenseFile(
+        config: FernGeneratorExec.GeneratorConfig,
+        rootDirectory: AbsoluteFilePath,
+        logger: Logger
+    ): Promise<void> {
+        if (config.license?.type === "custom") {
+            // For custom licenses, we need to get the license content from the source file
+            // The CLI should have read the license file content and made it available
+            // For now, we'll read the license file from the original location
+
+            try {
+                // The license file path is relative to the fern config directory
+                // We need to construct the full path to read the license content
+                const licenseFileName = config.license.filename ?? "LICENSE";
+                const licenseFilePath = path.join(rootDirectory, licenseFileName);
+
+                await this.copyLicenseFile(licenseFilePath);
+                logger.debug(`Successfully wrote LICENSE file to ${licenseFilePath}`);
+            } catch (error) {
+                // If we can't read the license file, we'll skip writing it
+                // This maintains backwards compatibility
+                logger.warn(`Failed to write LICENSE file: ${error instanceof Error ? error.message : String(error)}`);
+            }
+        }
+    }
+
+    private async copyLicenseFile(destinationPath: string): Promise<void> {
+        // In Docker execution environment, the license file is mounted at /tmp/LICENSE
+        const dockerLicensePath = "/tmp/LICENSE";
+
+        try {
+            await copyFile(dockerLicensePath, destinationPath);
+        } catch (error) {
+            throw new Error(
+                `Could not copy license file from ${dockerLicensePath}: ${error instanceof Error ? error.message : String(error)}`
+            );
+        }
+    }
+
     private async postProcess(
         persistedTypescriptProject: PersistedTypescriptProject,
         _customConfig: SdkCustomConfig

generators/typescript/sdk/client-class-generator/src/GeneratedSdkClientClassImpl.ts

@@ -1274,6 +1274,12 @@ export class GeneratedSdkClientClassImpl implements GeneratedSdkClientClass {
                     header: context.ir.sdkConfig.platformHeaders.userAgent.header,
                     value: ts.factory.createStringLiteral(context.ir.sdkConfig.platformHeaders.userAgent.value)
                 });
+            } else if (this.npmPackage != null) {
+                // Fallback: generate User-Agent header from npm package info
+                headers.push({
+                    header: "User-Agent",
+                    value: ts.factory.createStringLiteral(`${this.npmPackage.packageName}/${this.npmPackage.version}`)
+                });
             }
 
             const generatedVersion = context.versionContext.getGeneratedVersion();

generators/typescript/sdk/generator/src/TypeScriptGeneratorAgent.ts

@@ -1,4 +1,4 @@
-import { AbstractGeneratorAgent } from "@fern-api/base-generator";
+import { AbstractGeneratorAgent, RawGithubConfig } from "@fern-api/base-generator";
 import { Logger } from "@fern-api/logger";
 import { FernGeneratorCli } from "@fern-fern/generator-cli-sdk";
 import { FernGeneratorExec } from "@fern-fern/generator-exec-sdk";
@@ -70,13 +70,14 @@ export class TypeScriptGeneratorAgent extends AbstractGeneratorAgent<SdkContext>
         };
     }
 
-    public getGitHubConfig(args: AbstractGeneratorAgent.GitHubConfigArgs<SdkContext>): FernGeneratorCli.GitHubConfig {
+    public getGitHubConfig(args: AbstractGeneratorAgent.GitHubConfigArgs<SdkContext>): RawGithubConfig {
         // TODO: get from env
         return {
-            sourceDirectory: "NONE",
-            uri: "NONE",
-            token: "token",
-            branch: "NONE"
+            sourceDirectory: "fern/output",
+            type: this.publishConfig?.type,
+            uri: this.publishConfig?.type === "github" ? this.publishConfig.uri : undefined,
+            token: this.publishConfig?.type === "github" ? this.publishConfig.token : undefined,
+            mode: this.publishConfig?.type === "github" ? this.publishConfig.mode : undefined
         };
     }
 }

generators/typescript/sdk/versions.yml

@@ -1,4 +1,12 @@
 # yaml-language-server: $schema=../../../fern-versions-yml.schema.json
+- version: 3.28.3
+  changelogEntry:
+    - summary: |
+        Fix local GitHub generation to match remote generation.
+      type: fix
+  createdAt: "2025-11-06"
+  irVersion: 61
+
 - version: 3.28.2
   changelogEntry:
     - summary: |