chore: force osutils.abssymlink to internal, removing it

The only users of this is osutils.abspath which is slated
for removal in 0.12.0, thus block any further usage of this.

Signed-off-by: Brian Harring <ferringb@gmail.com>

Author: ferringb

NEWS.rst

@@ -50,9 +50,6 @@ API deprecations
 - snakeoil.osutils.abspath: Will be removed in 0.12.0
   Use ``os.path.abspath``.
 
-- snakeoil.osutils.abssymlink: Will be removed in 0.12.0
-  Use ``os.path.*`` functions instead.  Be mindful that this protected against //, which ``os.path.*`` doesn't, but ``pathlib`` should.
-
 - snakeoil.osutils.join: Will be removed in 0.12.0
   Use ``os.path.join``.
 
@@ -106,6 +103,7 @@ API removals
 - function snakeoil.modules.load_module
 - function snakeoil.obj.popattr
 - function snakeoil.osutils.access
+- function snakeoil.osutils.abssymlink
 - function snakeoil.osutils.readdir
 - function snakeoil.osutils.stat_swallow_enoent
 - function snakeoil.osutils.alias

src/snakeoil/osutils/__init__.py

@@ -4,7 +4,6 @@
 
 __all__ = (
     "abspath",
-    "abssymlink",
     "ensure_dirs",
     "join",
     "pjoin",
@@ -178,11 +177,7 @@ def ensure_dirs(path, gid=-1, uid=-1, mode=0o777, minimal=True):
     return True
 
 
-@deprecated(
-    "Use os.path.* functions instead.  Be mindful that this protected against //, which os.path.* doesn't, but pathlib should",
-    removal_in=(0, 12, 0),
-)
-def abssymlink(path):
+def _abssymlink(path):
     """Return the absolute path of a symlink
 
     :param path: filepath to resolve
@@ -227,7 +222,7 @@ def abspath(path):
     """
     path = os.path.abspath(path)
     try:
-        return abssymlink(path)
+        return _abssymlink(path)
     except EnvironmentError as e:
         if e.errno not in (errno.ENOENT, errno.EINVAL):
             raise

tests/test_osutils.py

@@ -186,7 +186,7 @@ def test_abssymlink(self, tmp_path):
         linkname = tmp_path / "link"
         target.mkdir()
         linkname.symlink_to("target")
-        assert osutils.abssymlink(linkname) == str(target)
+        assert osutils._abssymlink(linkname) == str(target)
 
 
 @deprecated.suppress_deprecations()